Revert "enable pfcwd for backplane ports (#3759)"#3767
Merged
yejianquan merged 1 commit intosonic-net:masterfrom Feb 17, 2025
Merged
Revert "enable pfcwd for backplane ports (#3759)"#3767yejianquan merged 1 commit intosonic-net:masterfrom
yejianquan merged 1 commit intosonic-net:masterfrom
Conversation
This reverts commit 2866ccd.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@abdosi @zhixzhu @alpeshspatel @rraghav-cisco @yejianquan for review |
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-utilities.msft#122 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2866ccd.
After PFCWD is enabled on backplane in #3759, qos/test_qos_sai.py::TestQosSai::testQosSaiPfcXoffLimit[single_dut_multi_asic-xoff_1] and all non single-asic cases failed with the following error:
as egress port is tx_disabled, PFC is generated from egress port back to backplane and triggered pfcwd on supervisor card. hence resulting in packet drop.
What I did
Reverted back PR #3759
How I did it
Reverted back PR #3759
How to verify it
PFCtest passed after applying the patch manually. Full test_qos_sai is still running. will upload the result once it is done.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)