Add queuestat changes for aggregate VOQ counters

[vivekverma-arista]

This feature has been tracked in #1543
HLD PR: 1957

What I did

Add queuestat changes for aggregate VOQ counters.

How I did it

Existing CLI show queue counters --voq is being implemented for supervisor. This will access all the ASIC database instances on every linecard which are now exposed to midplane network by this PR20803 and sum up counters for each VOQ.

Also depends on #560

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

[kenneth-arista]

@arlakshm for awareness

[kenneth-arista]

Tracking issue: sonic-net/SONiC#1543

[vmittal-msft]

@vivekverma-arista

1. Please share output from supervisor as well as line card using one port/voq as an example.
2. Do we have separate PR for clear counter ?
3. Did we check if queuestat still works for non chassis ?

[vmittal-msft]

Otherwise changes looks ok to me.

[vivekverma-arista]

@vivekverma-arista

1. Please share output from supervisor as well as line card using one port/voq as an example.
2. Do we have separate PR for clear counter ?
3. Did we check if queuestat still works for non chassis ?

Hi @vmittal-msft, I will answer/address these points. Meanwhile could you also take a look at another related PR sonic-net/sonic-buildimage#20803 and confirm that the approach is okay so that we can start making progress with unit tests.

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vmittal-msft]

Approved the dependent PR, please help answer few questions i pasted above.

[vivekverma-arista]

PR20803

@vmittal-msft

1. Manual testing with traffic for System Port cmp217-5|asic1|Ethernet256

From Linecard

admin@cmp217-5:~$ show queue counters -n asic0 "cmp217-5|asic1|Ethernet256" --voq
For namespace asic0:
                      Port    Voq    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes    Credit-WD-Del/pkts
--------------------------  -----  --------------  ---------------  -----------  ------------  --------------------
cmp217-5|asic1|Ethernet256   VOQ0             123             6150            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ1              12              600            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ2            1000            50000            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ3             456            22800            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ4             211            10550            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ5              45             2250            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ6              24             1200            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ7               0                0            0             0                     0

admin@cmp217-5:~$ show queue counters -n asic1 "cmp217-5|asic1|Ethernet256" --voq
For namespace asic1:
                      Port    Voq    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes    Credit-WD-Del/pkts
--------------------------  -----  --------------  ---------------  -----------  ------------  --------------------
cmp217-5|asic1|Ethernet256   VOQ0            1111            55550            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ1              45             2250            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ2               9              450            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ3              91             4550            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ4              55             2750            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ5              88             4400            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ6              21             1050            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ7              48            14437            0             0                     0

From supervisor

admin@cmp217:~$ show queue counters "cmp217-5|asic1|Ethernet256" --voq
                      Port    Voq    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes    Credit-WD-Del/pkts
--------------------------  -----  --------------  ---------------  -----------  ------------  --------------------
cmp217-5|asic1|Ethernet256   VOQ0            1234            61700            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ1              57             2850            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ2            1009            50450            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ3             547            27350            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ4             266            13300            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ5             133             6650            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ6              45             2250            0             0                     0
cmp217-5|asic1|Ethernet256   VOQ7              52            15809            0             0                     0

2. Clear functionality is not currently supported for aggregated VOQ counters on supervisor and would need some more work.

3. Queuestat still works fine on T0/T1 devices.

[vmittal-msft]

@vivekverma-arista Changes looks good to me. Please add clear counter support to it as well for SUP as well as LC (if not there).

[vmittal-msft]

@vivekverma-arista Please share if you are going to handle clear counter as part of this PR or different PR.

[vivekverma-arista]

@vivekverma-arista Please share if you are going to handle clear counter as part of this PR or different PR.

I will raise a separate PR for clear support as it needs additional work.

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vmittal-msft]

@vivekverma-arista please check failures.

[vmittal-msft]

@vivekverma-arista @kenneth-arista please check failures.

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[vivekverma-arista]

@vmittal-msft all PR checks have passed, please help merge this PR