[Draft] Add remote compatible show ip bgp and -n all for show ip bgp network#3413
Closed
BYGX-wcr wants to merge 16 commits intosonic-net:masterfrom
Closed
[Draft] Add remote compatible show ip bgp and -n all for show ip bgp network#3413BYGX-wcr wants to merge 16 commits intosonic-net:masterfrom
BYGX-wcr wants to merge 16 commits intosonic-net:masterfrom
Conversation
… show ip bgp network
wenyiz2021
reviewed
Jul 12, 2024
wenyiz2021
reviewed
Jul 12, 2024
| ctx.fail('-n/--namespace option required. provide namespace from list {}'\ | ||
| .format(multi_asic.get_namespace_list())) | ||
| namespace = namespace.strip() | ||
| if multi_asic.is_multi_asic(): |
Contributor
There was a problem hiding this comment.
I know you are just keeping original logic here, that if it is multi-asic, and namespace is not provided, error out.
but I think original logic may not be updated, can you change to: if multi asic, and namespace is not provided, print for all asics?
refer to: #2427
another pros for this is, you are running this cmd on sup, if one chassis has both multi/single-asic LCs, show ip bgp sum will output for all LCs, instead of having multi-asic LC error out, in this case we could have at least cmd working for both multi/single-asic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I enable the direct execution of "show ip bgp" on chassis supervisor and "-n all" option for "show ip bgp network" on multi-asic machine
How I did it
How to verify it
On chassis supervisor, run "show ip bgp ..."
On a multi-asic device, run "show ip bgp network -n all"
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)