Skip to content

Remove explicit dependency on tabulate; Add comments#336

Merged
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:remove_tabulate
Oct 10, 2018
Merged

Remove explicit dependency on tabulate; Add comments#336
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:remove_tabulate

Conversation

@jleveque
Copy link
Contributor

@jleveque jleveque commented Oct 8, 2018

The latest version of Python tabulate library available as a Debian package for Stretch is 0.7.7. However, the new "show vlan" command requires support for multi-line output in a cell, a feature that was added in tabulate v0.8.1.

Tabulate v0.8.2 is the latest version available via pip, so I am now installing this package in the base image here: sonic-net/sonic-buildimage#2130

I have also added comments describing the change and listing the packages that we cannot currently specify as explicit dependencies because they cannot be installed as .deb packages.

@jleveque jleveque self-assigned this Oct 8, 2018
@jleveque jleveque requested a review from lguohan October 8, 2018 20:12
@jleveque jleveque merged commit 9a139ab into sonic-net:master Oct 10, 2018
@jleveque jleveque deleted the remove_tabulate branch October 10, 2018 18:36
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants