[config]Support single file reload for multiasic#3349
Merged
wen587 merged 8 commits intosonic-net:masterfrom Jun 18, 2024
Merged
[config]Support single file reload for multiasic#3349wen587 merged 8 commits intosonic-net:masterfrom
wen587 merged 8 commits intosonic-net:masterfrom
Conversation
qiluo-msft
reviewed
Jun 11, 2024
qiluo-msft
reviewed
Jun 11, 2024
qiluo-msft
reviewed
Jun 11, 2024
qiluo-msft
reviewed
Jun 11, 2024
qiluo-msft
reviewed
Jun 11, 2024
wen587
changed the title
qiluo-msft
reviewed
Jun 12, 2024
qiluo-msft
reviewed
Jun 12, 2024
qiluo-msft
reviewed
Jun 12, 2024
| return client, config_db | ||
|
|
||
|
|
||
| def migrate_db_to_lastest(namespace=DEFAULT_NAMESPACE): |
qiluo-msft
reviewed
Jun 12, 2024
| clicommon.run_command(command, display_cmd=True) | ||
|
|
||
|
|
||
| def multiasic_write_to_db(filename, load_sysinfo): |
Contributor
There was a problem hiding this comment.
@rlhui @abdosi @judyjoseph Could you help review?
qiluo-msft
reviewed
Jun 12, 2024
qiluo-msft
reviewed
Jun 12, 2024
xincunli-sonic
approved these changes
Jun 12, 2024
Contributor
|
looks ok to me. Btw are you validating the switch booting up with a single config file ? or this is just "config reload" command changes. I have this question, because there could be startup scripts where we explicitly check for the presence of config_db.json |
Contributor
Author
This is just config reload command and it will not impact booting up. |
qiluo-msft
approved these changes
Jun 14, 2024
Contributor
|
@gechiang Could you help backport? |
wen587
added a commit
to wen587/sonic-utilities
that referenced
this pull request
Aug 8, 2024
ADO: 27595279 What I did Extend config reload to support single file reloading for multi-asic How I did it Add the single file reload support for mutli-asic How to verify it Unit test and manual test on multi-asic DUT
Contributor
Author
bingwang-ms
pushed a commit
that referenced
this pull request
Aug 8, 2024
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
ADO: 27595279 What I did Extend config reload to support single file reloading for multi-asic How I did it Add the single file reload support for mutli-asic How to verify it Unit test and manual test on multi-asic DUT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADO: 27595279
What I did
Extend config reload to support single file reloading for multi-asic
How I did it
Add the single file reload support for mutli-asic
How to verify it
Unit test and manual test on multi-asic DUT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)