-
Notifications
You must be signed in to change notification settings - Fork 816
Add CLI for bmp configdb entity Enable/Disable. #3260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3916,6 +3916,166 @@ def del_user(db, user): | |
| click.echo("Restart service snmp failed with error {}".format(e)) | ||
| raise click.Abort() | ||
|
|
||
| # | ||
| # 'bmp' group ('config bmp ...') | ||
| # | ||
|
|
||
| @config.group() | ||
| @click.pass_context | ||
| def bmp(ctx): | ||
| """BMP-related configuration""" | ||
|
|
||
| # | ||
| # 'enable' subgroup ('config bmp enable ...') | ||
| # | ||
| @bmp.group() | ||
| @click.pass_context | ||
| def enable(ctx): | ||
| """Enable BMP table dump """ | ||
|
|
||
| # | ||
| # 'bgp-neighbor-table' command ('config bmp enable bgp-neighbor-table') | ||
| # | ||
| @enable.command('bgp-neighbor-table') | ||
| @click.pass_context | ||
| def enable_bgp_neighbor_table(ctx): | ||
| """enable bgp-neighbor-table sessions | ||
| In the case of Multi-Asic platform, corresponding database instance of neighbor will be operated. | ||
| """ | ||
| log.log_info("'bmp enable bgp-neighbor-table' executing...") | ||
| config_db = ConfigDBConnector() | ||
| config_db.connect() | ||
| bmp_table = config_db.get_table('BMP') | ||
| if not bmp_table: | ||
| bmp_table = {'table': {'bgp_neighbor_table': 'true'}} | ||
| else: | ||
| bmp_table['table']['bgp_neighbor_table'] = 'true' | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed. and moved into #3286 since this PR was not created on fork branch. |
||
| try: | ||
| config_db.mod_entry('BMP', 'table', bmp_table['table']) | ||
| except ValueError as e: | ||
| ctx.fail("Invalid ConfigDB. Error: {}".format(e)) | ||
|
|
||
|
|
||
|
|
||
| # | ||
| # 'bgp-rib-out-table' command ('config bmp enable bgp-rib-out-table') | ||
| # | ||
| @enable.command('bgp-rib-out-table') | ||
| @click.pass_context | ||
| def enable_bgp_rib_out_table(ctx): | ||
| """enable bgp-rib-out-table sessions | ||
| In the case of Multi-Asic platform, corresponding database instance of neighbor will be operated. | ||
| """ | ||
| log.log_info("'bmp enable bgp-rib-out-table' executing...") | ||
| config_db = ConfigDBConnector() | ||
| config_db.connect() | ||
| bmp_table = config_db.get_table('BMP') | ||
| if not bmp_table: | ||
| bmp_table = {'table': {'bgp-rib-out-table': 'true'}} | ||
| else: | ||
| bmp_table['table']['bgp-rib-out-table'] = 'true' | ||
| try: | ||
| config_db.mod_entry('BMP', 'table', bmp_table['table']) | ||
| except ValueError as e: | ||
| ctx.fail("Invalid ConfigDB. Error: {}".format(e)) | ||
|
|
||
| # | ||
| # 'bgp-rib-in-table' command ('config bmp enable bgp-rib-in-table') | ||
| # | ||
| @enable.command('bgp-rib-in-table') | ||
| @click.pass_context | ||
| def enable_bgp_rib_out_table(ctx): | ||
| """enable bgp-rib-in-table sessions | ||
| In the case of Multi-Asic platform, corresponding database instance of neighbor will be operated. | ||
| """ | ||
| log.log_info("'bmp enable bgp-rib-in-table' executing...") | ||
| config_db = ConfigDBConnector() | ||
| config_db.connect() | ||
| bmp_table = config_db.get_table('BMP') | ||
| if not bmp_table: | ||
| bmp_table = {'table': {'bgp-rib-in-table': 'true'}} | ||
| else: | ||
| bmp_table['table']['bgp-rib-in-table'] = 'true' | ||
| try: | ||
| config_db.mod_entry('BMP', 'table', bmp_table['table']) | ||
| except ValueError as e: | ||
| ctx.fail("Invalid ConfigDB. Error: {}".format(e)) | ||
|
|
||
| # | ||
| # 'disable' subgroup ('config bmp disable ...') | ||
| # | ||
| @bmp.group() | ||
| @click.pass_context | ||
| def disable(ctx): | ||
| """Disable BMP table dump """ | ||
|
|
||
| # | ||
| # 'bgp-neighbor-table' command ('config bmp disable bgp-neighbor-table') | ||
| # | ||
| @disable.command('bgp-neighbor-table') | ||
| @click.pass_context | ||
| def disable_bgp_neighbor_table(ctx): | ||
| """disable bgp-neighbor-table sessions | ||
| In the case of Multi-Asic platform, corresponding database instance of neighbor will be operated. | ||
| """ | ||
| log.log_info("'bmp disable bgp-neighbor-table' executing...") | ||
| config_db = ConfigDBConnector() | ||
| config_db.connect() | ||
| bmp_table = config_db.get_table('BMP') | ||
| if not bmp_table: | ||
| bmp_table = {'table': {'bgp-neighbor-table': 'false'}} | ||
| else: | ||
| bmp_table['table']['bgp-neighbor-table'] = 'false' | ||
| try: | ||
| config_db.mod_entry('BMP', 'table', bmp_table['table']) | ||
| except ValueError as e: | ||
| ctx.fail("Invalid ConfigDB. Error: {}".format(e)) | ||
|
|
||
| # | ||
| # 'bgp-rib-out-table' command ('config bmp disable bgp-rib-out-table') | ||
| # | ||
| @enable.command('bgp-rib-out-table') | ||
| @click.pass_context | ||
| def diable_bgp_rib_out_table(ctx): | ||
| """disable bgp-rib-out-table sessions | ||
| In the case of Multi-Asic platform, corresponding database instance of neighbor will be operated. | ||
| """ | ||
| log.log_info("'bmp disable bgp-rib-out-table' executing...") | ||
| config_db = ConfigDBConnector() | ||
| config_db.connect() | ||
| bmp_table = config_db.get_table('BMP') | ||
| if not bmp_table: | ||
| bmp_table = {'table': {'bgp-rib-out-table': 'false'}} | ||
| else: | ||
| bmp_table['table']['bgp-rib-out-table'] = 'false' | ||
| try: | ||
| config_db.mod_entry('BMP', 'table', bmp_table['table']) | ||
| except ValueError as e: | ||
| ctx.fail("Invalid ConfigDB. Error: {}".format(e)) | ||
|
|
||
|
|
||
| # | ||
| # 'bgp-rib-in-table' command ('config bmp disable bgp-rib-in-table') | ||
| # | ||
| @enable.command('bgp-rib-in-table') | ||
| @click.pass_context | ||
| def disable_bgp_rib_out_table(ctx): | ||
| """disable bgp-rib-in-table sessions | ||
| In the case of Multi-Asic platform, corresponding database instance of neighbor will be operated. | ||
| """ | ||
| log.log_info("'bmp disable bgp-rib-in-table' executing...") | ||
| config_db = ConfigDBConnector() | ||
| config_db.connect() | ||
| bmp_table = config_db.get_table('BMP') | ||
| if not bmp_table: | ||
| bmp_table = {'table': {'bgp-rib-in-table': 'false'}} | ||
| else: | ||
| bmp_table['table']['bgp-rib-in-table'] = 'false' | ||
| try: | ||
| config_db.mod_entry('BMP', 'table', bmp_table['table']) | ||
| except ValueError as e: | ||
| ctx.fail("Invalid ConfigDB. Error: {}".format(e)) | ||
|
|
||
| # | ||
| # 'bgp' group ('config bgp ...') | ||
| # | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add unit test and ensure each changed line covered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed. and moved into #3286 since this PR was not created on fork branch.