Fix for Db migrator & Vlan Changes#3243
Conversation
|
@wen587 @qiluo-msft |
config/vlan.py
Outdated
| if "mode" in port_data: | ||
| existing_mode = port_data["mode"] | ||
|
|
||
| if existing_mode == "routed": |
There was a problem hiding this comment.
If "mode" not in port_data, the existing_mode should be undefined.
Why is it not caught by build or test?
|
Hi @sabakram , I tried submodule without your PR. sonic-net/sonic-buildimage#18480 It pass sonic-mgmt test. I suggest to revert it first to unblock submodule update. |
|
Hi @wen587 , ok we can revert this PR to avoid blocking for submodule head. but this revert is already done once earler. |
|
Hi @sabakram , sure I'm willing to help with the review |
e6f1b69 to
bdc5720
Compare
What I did
This PR is Fixture for #3108. We have removed dbmigrator changes to avoid backward compatibility issues.
How I did it
Removed Dbmigrator changes from dbmigrator.py and dbmigrator_test.py
How to verify it
Dbmigrator changes has been removed