Add Multi ASIC support for apply-patch#3219
Closed
xincunli-sonic wants to merge 0 commit intosonic-net:masterfrom
xincunli-sonic:xincun/gcu-multiasic
Closed
Add Multi ASIC support for apply-patch#3219xincunli-sonic wants to merge 0 commit intosonic-net:masterfrom xincunli-sonic:xincun/gcu-multiasic
xincunli-sonic wants to merge 0 commit intosonic-net:masterfrom
xincunli-sonic:xincun/gcu-multiasic
Conversation
VladimirKuk
reviewed
Mar 18, 2024
config/main.py
Outdated
| print("Patch: {}".format(patch)) | ||
| # Iterate over each change in the JSON Patch | ||
| for change in patch: | ||
| asic_id, modified_path = extract_asic_id(change["path"]) |
There was a problem hiding this comment.
What happens if "path" not in change? #Resolved
Contributor
Author
There was a problem hiding this comment.
According to RFC: https://www.rfc-editor.org/rfc/rfc6902#section-4, operation objects MUST have exactly one "path" member.
VladimirKuk
reviewed
Mar 18, 2024
config/main.py
Outdated
| if not clicommon.is_ipaddress(ntp_ip_address): | ||
| ctx.fail('Invalid IP address') | ||
| db = ValidatedConfigDBConnector(ctx.obj['db']) | ||
| db = ValidatedConfigDBConnector(ctx.obj['db']) |
There was a problem hiding this comment.
What happens if "db" not in ctx.obj? #Resolved
Contributor
|
Do we support HLD |
wen587
reviewed
Mar 19, 2024
Contributor
Author
Yes, it will be in another further pr to address the HLD mentioned checkpoint and rollback part. |
wen587
reviewed
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Add Multi-ASIC GCU support apply-patch.
How I did it
How to verify it
[ { "op": "add", "path": "/asic0/PORTCHANNEL/PortChannel108/admin_status", "value": "down" }, { "op": "replace", "path": "/localhost/BGP_DEVICE_GLOBAL/STATE/tsa_enabled", "value": "true" }, { "op": "replace", "path": "/asic0/BGP_DEVICE_GLOBAL/STATE/tsa_enabled", "value": "true" }, { "op": "replace", "path": "/asic1/BGP_DEVICE_GLOBAL/STATE/tsa_enabled", "value": "true" } ]Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)