Fix to use IPv6 linklocal address as snmp agent address by SuvarnaMeenakshi · Pull Request #3215 · sonic-net/sonic-utilities

SuvarnaMeenakshi · 2024-03-13T06:50:57Z

What I did

If link local IPv6 address is added as SNMP agent address, it will fail.
This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350

How I did it

Append scope id to ipv6 link local IP address.

How to verify it

Able to configure link local ipv6 address as snmp agent address

sudo config snmpagentaddress add fe80::2a99:3aff:fe17:1c08%eth0


 sonic-db-cli CONFIG_DB keys "*SNMP*AGENT*"
SNMP_AGENT_ADDRESS_CONFIG|FC00:1::32|161|
SNMP_AGENT_ADDRESS_CONFIG|2a01::ae|161|
SNMP_AGENT_ADDRESS_CONFIG|10.1.0.32|161|
SNMP_AGENT_ADDRESS_CONFIG|10..0.13|161|
SNMP_AGENT_ADDRESS_CONFIG|fe80::2a99:3aff:fe17:1c08%eth0||
..
SNMP_AGENT_ADDRESS_CONFIG|fe80::3a38:a6ff:fe98:e960%eth0||  ---- Newly added agent IP along with zone id
SNMP_AGENT_ADDRESS_CONFIG|FC00:1::32|161|
SNMP_COMMUNITY|<>
...

docker exec -it snmp cat /etc/snmp/snmpd.conf | grep agentAddress
agentAddress udp:[10.1.0.32]:161
agentAddress udp:[10.0.0.13]:161
agentAddress udp6:[2a01::a]:161
agentAddress udp6:[FC00:1::32]:161
agentAddress udp6:[fe80::2a99:3aff:fe17:1c08%eth0]

docker exec -it snmp snmpwalk -v2c -c <comm> fe80::2a99:3aff:fe17:1c08%eth0 1.3.6.1.2.1.1.1.0
iso.3.6.1.2.1.1.1.0 = STRING: "SONiC Software Version: SONiC.<> - HwSku: Arista-<> - Distribution: Debian 11.10 - Kernel: 5.10.0-23-2-amd64"

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

keboliu · 2024-03-18T03:33:45Z

@SuvarnaMeenakshi would you please address the covrage issue?

dgsudharsan · 2024-04-24T04:12:41Z

@SuvarnaMeenakshi Can you please address the coverage issue?

bingwang-ms · 2024-04-24T15:30:14Z

@SuvarnaMeenakshi Please fix the coverage issue. Appreciate if you can share an ETA.

keboliu · 2024-05-13T09:18:01Z

@SuvarnaMeenakshi would you please fix the coverage issue?

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

keboliu · 2024-05-23T10:23:51Z

@qiluo-msft would you please review?

local ip Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi · 2024-05-23T17:11:46Z

@qiluo-msft @keboliu
Can we set the expectation that while adding snmpAgent address using CLI, the zone id will be added by the use or in the configuration.
For example: sudo config snmpagentaddress add fe80::3a38:a6ff:fe98:e960%eth0

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

config/main.py

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

keboliu · 2024-06-07T02:35:49Z

@SuvarnaMeenakshi seems there is a unit test issue, would you please check?

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

using cli Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

Modify snmp_link_local_test to test after configuring link local snmp agent address using config snmpagentaddress cli. Pre requisite: sonic-net/sonic-utilities#3215 Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

What I did If link local IPv6 address is added as SNMP agent address, it will fail. This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350 How I did it Append scope id to ipv6 link local IP address. How to verify it Able to configure link local ipv6 address as snmp agent address sudo config snmpagentaddress add fe80::a%eth0

mssonicbld · 2024-08-12T17:23:16Z

Cherry-pick PR to 202405: #3487

What I did If link local IPv6 address is added as SNMP agent address, it will fail. This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350 How I did it Append scope id to ipv6 link local IP address. How to verify it Able to configure link local ipv6 address as snmp agent address sudo config snmpagentaddress add fe80::a%eth0

Modify snmp_link_local_test to test after configuring link local snmp agent address using config snmpagentaddress cli. Pre requisite: sonic-net/sonic-utilities#3215 Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

What I did If link local IPv6 address is added as SNMP agent address, it will fail. This PR requires changes in snmpd.conf.j2 template here sonic-net/sonic-buildimage#18350 How I did it Append scope id to ipv6 link local IP address. How to verify it Able to configure link local ipv6 address as snmp agent address sudo config snmpagentaddress add fe80::a%eth0

Fix to use IPv6 linklocal address as snmp agent address

02cc0fa

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

This was referenced Mar 13, 2024

Timeout error while fetching response using snmpget sonic-net/sonic-buildimage#17807

Closed

[snmp] Snmpd fails to start when mgmt or Loopback interface is configured with Link local IPv6 address sonic-net/sonic-buildimage#16001

Open

keboliu added the Request for 202311 Branch label Mar 13, 2024

keboliu requested a review from qiluo-msft April 15, 2024 06:28

SuvarnaMeenakshi added 4 commits May 20, 2024 15:59

Add unit-test

bbde4a4

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

fix ut

fefb642

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

Fix flake8

4b52448

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

fix flake8

33bc656

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

Modify cli to add agent ip along with zone id for link

f56f61a

local ip Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi added the Not Ready to Merge label May 23, 2024

SuvarnaMeenakshi removed the Not Ready to Merge label May 30, 2024

SuvarnaMeenakshi mentioned this pull request May 30, 2024

Modify snmp link local test to use config cli sonic-net/sonic-mgmt#13070

Merged

8 tasks

Fix to add zone id in config command

6d7f532

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

qiluo-msft reviewed May 31, 2024

View reviewed changes

config/main.py Outdated Show resolved Hide resolved

Update as per review comment

68fc8ea

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi removed the Request for 202311 Branch label Jun 10, 2024

SuvarnaMeenakshi mentioned this pull request Jun 14, 2024

SNMP_AGENT_ADDRESS_CONFIG configuration does not work for link local IP sonic-net/sonic-mgmt#10766

Open

qiluo-msft previously approved these changes Jul 22, 2024

View reviewed changes

Fix unit test

f8db6d4

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi dismissed qiluo-msft’s stale review via f8db6d4 July 29, 2024 15:22

Fix check to match interface ip and agent ip being added

709b9d6

using cli Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

qiluo-msft previously approved these changes Aug 2, 2024

View reviewed changes

netifaces provides ipadress along with zoneid

214b222

Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>

SuvarnaMeenakshi dismissed qiluo-msft’s stale review via 214b222 August 2, 2024 22:18

qiluo-msft approved these changes Aug 2, 2024

View reviewed changes

SuvarnaMeenakshi merged commit 018eb73 into sonic-net:master Aug 5, 2024

SuvarnaMeenakshi added the Request for 202405 Branch label Aug 5, 2024

bingwang-ms added the Approved for 202405 Branch label Aug 12, 2024

mssonicbld mentioned this pull request Aug 12, 2024

[action] [PR:3215] Fix to use IPv6 linklocal address as snmp agent address (#3215) #3487

Merged

mssonicbld added the Created PR to 202405 Branch label Aug 12, 2024

mssonicbld added Included in 202405 Branch and removed Created PR to 202405 Branch labels Aug 12, 2024

mssonicbld mentioned this pull request Sep 3, 2024

[action] [PR:13070] Modify snmp link local test to use config cli sonic-net/sonic-mgmt#14406

Merged

8 tasks

mssonicbld mentioned this pull request Sep 6, 2024

[action] [PR:13070] Modify snmp link local test to use config cli sonic-net/sonic-mgmt#14454

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix to use IPv6 linklocal address as snmp agent address#3215

Fix to use IPv6 linklocal address as snmp agent address#3215
SuvarnaMeenakshi merged 11 commits intosonic-net:masterfrom
SuvarnaMeenakshi:linklocal_snmp

SuvarnaMeenakshi commented Mar 13, 2024 •

edited

Loading

Uh oh!

keboliu commented Mar 18, 2024

Uh oh!

dgsudharsan commented Apr 24, 2024

Uh oh!

bingwang-ms commented Apr 24, 2024

Uh oh!

keboliu commented May 13, 2024

Uh oh!

keboliu commented May 23, 2024

Uh oh!

SuvarnaMeenakshi commented May 23, 2024

Uh oh!

Uh oh!

keboliu commented Jun 7, 2024

Uh oh!

mssonicbld commented Aug 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

SuvarnaMeenakshi commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

keboliu commented Mar 18, 2024

Uh oh!

dgsudharsan commented Apr 24, 2024

Uh oh!

bingwang-ms commented Apr 24, 2024

Uh oh!

keboliu commented May 13, 2024

Uh oh!

keboliu commented May 23, 2024

Uh oh!

SuvarnaMeenakshi commented May 23, 2024

Uh oh!

Uh oh!

keboliu commented Jun 7, 2024

Uh oh!

mssonicbld commented Aug 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SuvarnaMeenakshi commented Mar 13, 2024 •

edited

Loading