Fix the sfputil treats page number as decimal instead of hexadecimal#3147
Closed
yuazhe wants to merge 1 commit intosonic-net:masterfrom
Closed
Fix the sfputil treats page number as decimal instead of hexadecimal#3147yuazhe wants to merge 1 commit intosonic-net:masterfrom
yuazhe wants to merge 1 commit intosonic-net:masterfrom
Conversation
keboliu
approved these changes
Feb 2, 2024
mihirpat1
reviewed
Feb 2, 2024
Contributor
mihirpat1
left a comment
There was a problem hiding this comment.
Please attach the CLI output with hex page number as 10 and 11
Contributor
Author
updated. |
sonic-net#3009 breaks the number base rule, treats the page number CLI input as decimal rather than hex, this is used to fix it. it also containes a redundancy function definition, so remove it. Signed-off-by: Yuanzhe, Liu <[email protected]>
Junchao-Mellanox
approved these changes
Feb 2, 2024
prgeor
approved these changes
Feb 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
#3009 breaks the number base rule, treats the page number CLI input as decimal rather than hex, this is used to fix it.
it also containes a redundancy function definition, so remove it.
How I did it
How to verify it
unit test and manually test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)