[dualtor_neighbor_check] Adjust zero-mac check condition#3034
Merged
prsunny merged 2 commits intosonic-net:masterfrom Nov 6, 2023
Merged
[dualtor_neighbor_check] Adjust zero-mac check condition#3034prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
prsunny
reviewed
Nov 2, 2023
prsunny
approved these changes
Nov 6, 2023
yxieca
pushed a commit
that referenced
this pull request
Nov 8, 2023
* [dualtor_neighbor_check] Adjust zero-mac check condition
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 8, 2023
* [dualtor_neighbor_check] Adjust zero-mac check condition
Contributor
Author
yxieca
pushed a commit
that referenced
this pull request
Dec 4, 2023
* [dualtor_neighbor_check] Adjust zero-mac check condition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Work item tracking
Fix the
dualtor_neighbor_checkerror log complaining about the zero-mac neighbor inconsistency due to no tunnel route present in the ASIC.This is because, for zero-mac neighbors, two situations:
Signed-off-by: Longxiang Lyu lolv@microsoft.com
How I did it
Adjust the check condition.
How to verify it
UT and verify on testbed with expired neighbors.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)