Open
Conversation
Add the config cli for link event damping.
Author
| config_set = {} | ||
|
|
||
| if max_suppress_time is not None: | ||
| if max_suppress_time < 0: |
Collaborator
There was a problem hiding this comment.
could you please use click.IntRange for such validation? check https://click.palletsprojects.com/en/8.1.x/api/#click.IntRange
| @click.option('--suppress-threshold', required=False, type=int, help="Set suppress threshold") | ||
| @click.option('--reuse-threshold', required=False, type=int, help="Set reuse threshold") | ||
| @click.option('--flap-penalty', required=False, type=int, help="Set flap penalty") | ||
| def aied_param(ctx, interface_name, max_suppress_time, decay_half_life, suppress_threshold, reuse_threshold, flap_penalty): |
Collaborator
There was a problem hiding this comment.
do we need a show command for these parameters?
Contributor
|
@Ashish1805 , can you please rebase the PR? |
prsunny
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jun 4, 2024
What I did Added support for link event damping in SWSS. Required Syncd PR: sonic-net/sonic-sairedis#1297 CLI PR: sonic-net/sonic-utilities#3001 HLD: https://github.com/sonic-net/SONiC/blob/master/doc/link_event_damping/Link-event-damping-HLD.md Why I did it How I verified it Use the config interface damping CLI to set the port attributes on the switch and observe that Syncd processes link event damping parameters.
henrymao-zz
pushed a commit
to canonical/sonic-swss
that referenced
this pull request
Jun 23, 2024
What I did Added support for link event damping in SWSS. Required Syncd PR: sonic-net/sonic-sairedis#1297 CLI PR: sonic-net/sonic-utilities#3001 HLD: https://github.com/sonic-net/SONiC/blob/master/doc/link_event_damping/Link-event-damping-HLD.md Why I did it How I verified it Use the config interface damping CLI to set the port attributes on the switch and observe that Syncd processes link event damping parameters.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did Added support for link event damping in SWSS. Required Syncd PR: sonic-net/sonic-sairedis#1297 CLI PR: sonic-net/sonic-utilities#3001 HLD: https://github.com/sonic-net/SONiC/blob/master/doc/link_event_damping/Link-event-damping-HLD.md Why I did it How I verified it Use the config interface damping CLI to set the port attributes on the switch and observe that Syncd processes link event damping parameters.
|
Hi @Ashish1805, @Junchao-Mellanox, and @prsunny, This PR has been inactive for nearly 2 years. I'm picking up the link event damping feature and plan to open a new PR that supersedes this one with the following improvements: Addressing review feedback:
Adding missing functionality:
New features based on industry feedback:
Will credit @Ashish1805 as original author. |
DendroLabs
added a commit
to DendroLabs/sonic-utilities
that referenced
this pull request
Mar 17, 2026
Implements CLI support for RFC 2439/7196 link event dampening: - config interface dampening enable/disable: configure AIED dampening with validation (IntRange per review feedback), monitor-only mode, and configurable flap-penalty - show interfaces dampening: display config and operational state from CONFIG_DB and STATE_DB with per-interface counters - sonic-clear interfaces dampening: reset penalty via STATE_DB flag Supersedes sonic-net#3001 with improvements: - click.IntRange validation (per @Junchao-Mellanox review) - Monitor-only mode per RFC 7196 "Calculate But Do Not Damp" - Configurable flap-penalty (vs hardcoded 1000) - Show command with operational state and counters - Clear command per RFC 2439 Section 4.8.6 Co-Authored-By: Ashish Singh <[email protected]> Co-Authored-By: Claude Opus 4.6 <[email protected]>
8 tasks
DendroLabs
added a commit
to DendroLabs/sonic-utilities
that referenced
this pull request
Mar 17, 2026
Implements CLI support for RFC 2439/7196 link event dampening: - config interface dampening enable/disable: configure AIED dampening with validation (IntRange per review feedback), monitor-only mode, and configurable flap-penalty - show interfaces dampening: display config and operational state from CONFIG_DB and STATE_DB with per-interface counters - sonic-clear interfaces dampening: reset penalty via STATE_DB flag Supersedes sonic-net#3001 with improvements: - click.IntRange validation (per @Junchao-Mellanox review) - Monitor-only mode per RFC 7196 "Calculate But Do Not Damp" - Configurable flap-penalty (vs hardcoded 1000) - Show command with operational state and counters - Clear command per RFC 2439 Section 4.8.6 Signed-off-by: DendroLabs <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added new config cli for link event damping and
How I did it
Added damping group in interface and added sub-commands algo and aied-param under damping group.
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)
N/A