Add drop probability configurability to ecnconfig#297
Merged
lguohan merged 3 commits intosonic-net:masterfrom Aug 16, 2018
Merged
Add drop probability configurability to ecnconfig#297lguohan merged 3 commits intosonic-net:masterfrom
lguohan merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Wenda <wenni@microsoft.com>
Signed-off-by: Wenda <wenni@microsoft.com>
lguohan
approved these changes
Aug 16, 2018
wendani
added a commit
to wendani/sonic-utilities
that referenced
this pull request
Aug 18, 2018
* Add drop probability configurability to ecnconfig Signed-off-by: Wenda <wenni@microsoft.com> * Correct variable names * Correct syntax error Signed-off-by: Wenda <wenni@microsoft.com>
lguohan
pushed a commit
that referenced
this pull request
Aug 19, 2018
… on/off status on queues (#303) * Add drop probability configurability to ecnconfig (#297) * Add drop probability configurability to ecnconfig Signed-off-by: Wenda <wenni@microsoft.com> * Correct variable names * Correct syntax error Signed-off-by: Wenda <wenni@microsoft.com> * Add the capability of show and change ECN on/off status on queues to ecnconfig Signed-off-by: Wenda Ni <wenni@microsoft.com> * Address comments: 1) usage format for ecn on/off; 2) add sample outputs * Address comments: 1) usage format for ecn on/off; 2) add sample outputs; 3) avoid variable name reuse for different entities; 4) iterate over dictionary key-value tuples using .items(); 5) replace SonicV2Connector.set() call by ConfigDBConnector.mod_entry() for performance improvement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenda wenni@microsoft.com
- What I did
- How I did it
- How to verify it
Tested on DUT with sonic-net/sonic-swss#571
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->