[201911] [multi_asic] Script to monitor errors on internal links#2966
Closed
[201911] [multi_asic] Script to monitor errors on internal links#2966
Conversation
tjchadaga
requested review from
abdosi,
arlakshm,
lguohan,
rlhui and
wenyiz2021
11 tasks
abdosi
reviewed
Sep 5, 2023
abdosi
reviewed
Sep 5, 2023
| self.error_counter_names = ['SAI_PORT_STAT_IF_IN_ERRORS', | ||
| 'SAI_PORT_STAT_IF_OUT_ERRORS'] | ||
| # Using fixed values for 201911 | ||
| self.threshold = 0 |
Contributor
There was a problem hiding this comment.
is comment applicable ? Is threshold configurable ?
Contributor
Author
There was a problem hiding this comment.
It is fixed for 201911, but would be read from configDB for master and newer branches
abdosi
reviewed
Sep 5, 2023
|
|
||
| def get_active_lag_member_count(self, namespace, lag_name): | ||
| ''' Returns number of member ports that are operationally up in the given portchannel ''' | ||
| lag_members = self.appdb[namespace].keys('APPL_DB', 'LAG_MEMBER_TABLE:{}:*'.format(lag_name)) |
Contributor
There was a problem hiding this comment.
can we use config db instead of appl db ?
Contributor
Author
There was a problem hiding this comment.
since we are looking for active (operationally up) lag members, does it matter if we check in appl db?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added script to monitor SAI_PORT_STAT_IF_IN_ERRORS & SAI_PORT_STAT_IF_OUT_ERRORS on internal (backend) ports of multi-asic device.
How I did it
Script is added to monit to regularly scan and check for errors on internal ports. If error count is above configured threshold, and the internal port-channel has more than min_links active links, then the port is shut down and syslog is generated.
How to verify it
UT cases are added to test the error detection.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)