[202211] [db_migrator.py] Fix issue while upgrading from 202205 to 202211 via fast reboot by Junchao-Mellanox · Pull Request #2962 · sonic-net/sonic-utilities

Junchao-Mellanox · 2023-08-31T08:37:54Z

Backport #2948 to 202211

What I did

Fix issue while upgrading from 202205 to 202211 via fast reboot. This issue is caused by a mismatch version handling for fast reboot in db_migrator.

In 202205, the db migrator for fast reboot flag handling is 3_0_5:

sonic-utilities/scripts/db_migrator.py

Line 920 in 56a1ae2

def version_3_0_5(self):

However, in master(202211), the db migrator for fast reboot flag handling is 4_0_0:

sonic-utilities/scripts/db_migrator.py

Line 993 in 7435b1c

def version_4_0_0(self):

This mismatch causes an incorrect sequence like this:

1. User issue fast-reboot under 202205
2. fast-reboot script set fast reboot flag by command "sonic-db-cli STATE_DB HSET "FAST_RESTART_ENABLE_TABLE|system" "enable" "true" &>/dev/null"
3. system boot to 202211
4. db_migrator found the database version is 3_0_6, it will run 4_0_0, however, it found FAST_REBOOT|system does not exist, and it set  FAST_RESTART_ENABLE_TABLE|system enable to false
5. system incorrectly performs cold reboot

How I did it

in db migrator if we see there is FAST_RESTART_ENABLE_TABLE already, we should skip fast reboot flag migration

How to verify it

unit test
manual test

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

…fast reboot Conflicts: scripts/db_migrator.py tests/db_migrator_test.py

Conflicts: tests/db_migrator_test.py

Junchao-Mellanox · 2023-09-04T10:05:25Z

Hi @StormLiangMS , could you please help merge this?

Junchao-Mellanox · 2023-09-13T07:23:30Z

Hi @StormLiangMS , could you please help merge this?

Junchao-Mellanox · 2023-09-26T09:23:13Z

/azpw run Azure.sonic-utilities

mssonicbld · 2023-09-26T09:23:15Z

/AzurePipelines run Azure.sonic-utilities

azure-pipelines · 2023-09-26T09:23:24Z