[chassis][multi-asic]Fix show acl table for masic#2937
Merged
rlhui merged 1 commit intosonic-net:masterfrom Aug 18, 2023
Merged
[chassis][multi-asic]Fix show acl table for masic#2937rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
judyjoseph
reviewed
Aug 16, 2023
judyjoseph
approved these changes
Aug 16, 2023
abdosi
approved these changes
Aug 17, 2023
Contributor
|
@arlakshm , please help create ado, thx. |
Contributor
Author
|
MSFT ADO 25067638 |
Contributor
|
@yxieca , @StormLiangMS , Can you help approve this bug fix for the corresponding requested branches? |
yxieca
pushed a commit
that referenced
this pull request
Sep 6, 2023
What I did Fixes sonic-net/sonic-buildimage#16012 The show acl table command currently get the ports from host config_db on multi asic platforms. This host config_db will not the phyiscal ports in the binding ports because the host doesnt have any front panel ports on the host. This causes the show acl table not to display the phyiscal ports in the output on multi asic devices/linecards. The test iface_namingmode/test_iface_namingmode.py::test_show_acl_table fails because of this issue.
StormLiangMS
pushed a commit
that referenced
this pull request
Sep 21, 2023
What I did Fixes sonic-net/sonic-buildimage#16012 The show acl table command currently get the ports from host config_db on multi asic platforms. This host config_db will not the phyiscal ports in the binding ports because the host doesnt have any front panel ports on the host. This causes the show acl table not to display the phyiscal ports in the output on multi asic devices/linecards. The test iface_namingmode/test_iface_namingmode.py::test_show_acl_table fails because of this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixes sonic-net/sonic-buildimage#16012
The
show acl tablecommand currently get the ports from host config_db on multi asic platforms.This host config_db will not the phyiscal ports in the binding ports because the host doesnt have any front panel ports on the host. This causes the
show acl tablenot to display the phyiscal ports in the output on multi asic devices/linecards.The test
iface_namingmode/test_iface_namingmode.py::test_show_acl_tablefails because of this issue.Details from the test failure
How I did it
For the
show acl tablecommand the following approach is followedHow to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)