[db_migrator] Migrate DNS configuratuion#2893
Merged
ganglyu merged 9 commits intosonic-net:masterfrom Jul 12, 2023
Merged
Conversation
vaibhavhd
reviewed
Jul 5, 2023
vaibhavhd
reviewed
Jul 5, 2023
vaibhavhd
previously approved these changes
Jul 5, 2023
Contributor
vaibhavhd
left a comment
vaibhavhd
left a comment
There was a problem hiding this comment.
Non blocking comments added.
Contributor
|
Did you manually tested the workflow of https://github.com/sonic-net/SONiC/wiki/L2-Switch-mode? |
qiluo-msft
reviewed
Jul 5, 2023
qiluo-msft
reviewed
Jul 5, 2023
qiluo-msft
reviewed
Jul 5, 2023
qiluo-msft
previously approved these changes
Jul 6, 2023
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please check with other reviewers.
vaibhavhd
reviewed
Jul 6, 2023
| """ | ||
| log.log_info('Handling version_4_0_3') | ||
| # Updating DNS nameserver | ||
| self.migrate_dns_nameserver() |
Contributor
There was a problem hiding this comment.
You updated the existing version, but did not create a new version.
Please add new version handler here as a placeholder.
Also, when you do that please also update the self.CURRENT_VERSION to the new version.
qiluo-msft
reviewed
Jul 6, 2023
Contributor
|
Please do not merge this change until #2895 is merged. 2895 fixes an issue where CURRENT_VERSION is not updated. |
Contributor
|
Please resolve the conflict. |
qiluo-msft
previously approved these changes
Jul 11, 2023
qiluo-msft
approved these changes
Jul 12, 2023
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@ganglyu do we have ADO for this? |
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
…to version 4_0_1 (sonic-net#2912) #### What I did In PR sonic-net#2893 the db_migrator "migrate_dns_nameserver" was misplaced in the latest version being version 4_0_4 instead of being placed in version 4_0_3. Additionally, the log info for version 4_0_1 was missing as well
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Jul 25, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
pdhruv-marvell
pushed a commit
to pdhruv-marvell/sonic-utilities
that referenced
this pull request
Aug 23, 2023
…to version 4_0_1 (sonic-net#2912) #### What I did In PR sonic-net#2893 the db_migrator "migrate_dns_nameserver" was misplaced in the latest version being version 4_0_4 instead of being placed in version 4_0_3. Additionally, the log info for version 4_0_1 was missing as well
rajkumar38
pushed a commit
to rajkumar38/sonic-utilities
that referenced
this pull request
Aug 28, 2023
What I did sonic-net/sonic-buildimage#14549 This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC. How I did it If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB. How to verify it Run unit test for db migrator.
Contributor
|
@ganglyu is this an enhancement? If yes, no for backport to 202305 |
Collaborator
|
Removing the cherry-pick tag since the feature of DNS is not part of 202305 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
sonic-net/sonic-buildimage#14549
This PR has introduced DNS configuration to CONFIG_DB, we need to migrate original CONFIG_DB to support DNS configuration during upgrading SONiC.
Microsoft ADO: 24408420
How I did it
If there's no DNS_NAMESERVER table in CONFIG_DB, read DNS_NAMESERVER table from minigraph and update CONFIG_DB.
How to verify it
Run unit test for db migrator.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)