[GCU Feature Update] Cherry-pick Platform Validator PR to 202205 #2883
Merged
yxieca merged 3 commits intosonic-net:202205from Jun 23, 2023
Merged
[GCU Feature Update] Cherry-pick Platform Validator PR to 202205 #2883yxieca merged 3 commits intosonic-net:202205from
yxieca merged 3 commits intosonic-net:202205from
Conversation
…net#2692) * add rdma gcu unit test * fix comment * clean unused code * clean format * extend to mock patchapplier, in place of changeapplier * replace tabs with spaces
Add GCU UT coverage to ensure each step of patch sorting is valid
Cherry-pick PR 2692, 2818, and 2857 to 202205
qiluo-msft
approved these changes
Jun 21, 2023
isabelmsft
added a commit
to isabelmsft/sonic-utilities
that referenced
this pull request
Jul 12, 2023
…205 (sonic-net#2883)" This reverts commit 436ecb0.
isabelmsft
added a commit
to isabelmsft/sonic-utilities
that referenced
this pull request
Aug 10, 2023
…ic-net#2883) * [GCU] Complete RDMA Platform Validator PR (sonic-net#2857) Cherry-pick PR 2692, 2818, and 2857 to 202205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADO 17747379
This PR cherry-picks three PRs to 202205 in the following order:
Motivation of cherry-pick is to add PR #2857 platform validator functionality to 202205. Without this PR, GCU does not have the ability to restrict updates to certain tables based on platform. This function is necessary for RDMA related tables. This platform validator PR uses a test file created and updated in PR #2692 and PR #2818, so all three PRs are cherry-picked together.
After this PR is merged, the sonic-mgmt test cases need to be updated: sonic-net/sonic-mgmt#8583