Configure NTP according to extended configuration#2835
Merged
liat-grozovik merged 5 commits intosonic-net:masterfrom Nov 9, 2023
Merged
Configure NTP according to extended configuration#2835liat-grozovik merged 5 commits intosonic-net:masterfrom
liat-grozovik merged 5 commits intosonic-net:masterfrom
Conversation
This was referenced May 13, 2023
fastiuk
force-pushed
the
dev-ntp-configuration
branch
from
3564598 to
09cc7d1
Compare
fastiuk
force-pushed
the
dev-ntp-configuration
branch
from
09cc7d1 to
da81c66
Compare
Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
dev-ntp-configuration
branch
from
da81c66 to
94946ac
Compare
saiarcot895
reviewed
Jul 21, 2023
saiarcot895
approved these changes
Sep 18, 2023
Contributor
|
Just want to make sure. Should this PR support all new configurations from the HLD, or there will be a separate PR? |
Contributor
Author
No, the new commands won't be supported by this PR |
Collaborator
|
could it be that the NTP command now looks different? |
liat-grozovik
approved these changes
Nov 9, 2023
liat-grozovik
changed the title
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Dec 11, 2023
hld [#1296](sonic-net/SONiC#1296) closes [#1254](sonic-net/SONiC#1254) depends-on [#60](sonic-net/sonic-host-services#60), [#781](sonic-net/sonic-swss-common#781), [#2835](sonic-net/sonic-utilities#2835), [#10749](sonic-net/sonic-mgmt#10749) #### Why I did it To cover the next AIs: * Configure NTP global parameters * Add/remove new NTP servers * Change the configuration for NTP servers * Show NTP status * Show NTP configuration ### How I did it * Add YANG model for a new configuration * Extend configuration templates to support new knobs ### Description for the changelog * Add ability to configure NTP global parameters such as authentication, dhcp, admin state * Change the configuration for NTP servers * Add an ability to show NTP configuration #### Link to config_db schema for YANG module changes [NTP configuration](https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#ntp-and-syslog-servers)
nmoray
pushed a commit
to nmoray/sonic-utilities
that referenced
this pull request
Jun 25, 2025
- What I did Fix NTP CLI according to new extended configuration abilities - How I did it Additionally configure association_type and resolve_as when adding new NTP servers. - How to verify it 1. Add a new server 2. Show NTP sync show ntp. It should show you are sync with new server 3. Delete NTP server 4. Show NTP sync show ntp. It should show you are unsync Signed-off-by: Yevhen Fastiuk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hld #1219
closes #1171
What I did
Fix NTP CLI according to new extended configuration abilities
How I did it
Additionally configure
association_typeandresolve_aswhen adding new NTP servers.How to verify it
show ntp. It should show you are sync with new servershow ntp. It should show you are unsyncPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
Not changed