Skip to content

[202211][route_check] fix IPv6 address handling #2798

Merged
StormLiangMS merged 2 commits intosonic-net:202211from
stepanblyschak:202211-route_check_ipv6
Apr 20, 2023
Merged

[202211][route_check] fix IPv6 address handling #2798
StormLiangMS merged 2 commits intosonic-net:202211from
stepanblyschak:202211-route_check_ipv6

Conversation

@stepanblyschak
Copy link
Copy Markdown
Contributor

BACKPORT of #2722

What I did

In case user has configured an IPv6 address on an interface in CONFIG DB in non simplified form like 2000:31:0:0::1/64 it is present in a simplified form in ASIC_DB. This leads to route_check failure since it just compares strings.

How I did it

Convert prefix string using ip_network().

How to verify it

UT replicates the issue.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@stepanblyschak stepanblyschak changed the title [route_check] fix IPv6 address handling [202211][route_check] fix IPv6 address handling Apr 18, 2023
@keboliu keboliu requested a review from StormLiangMS April 18, 2023 07:29
Copy link
Copy Markdown
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 86e3e00 into sonic-net:202211 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants