Skip to content

[Clock] Implement clock CLI#2793

Merged
yxieca merged 3 commits intosonic-net:masterfrom
fastiuk:dev-clock-commands
Jun 2, 2023
Merged

[Clock] Implement clock CLI#2793
yxieca merged 3 commits intosonic-net:masterfrom
fastiuk:dev-clock-commands

Conversation

@fastiuk
Copy link
Contributor

@fastiuk fastiuk commented Apr 13, 2023 •
edited
Loading

hld #1219
closes #1171

What I did

  • Add command to configure date and time
  • Add command to configure timezone
  • Add command to show timezones

How to verify it

Show clock and timezones:

show clock
show clock timezones

Set date and time and verify:

sudo config clock date-time <date> <time>
show clock

Set timezone and verify:

sudo config clock timezone <timezone>
show clock

Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ show clock
Sat 10 Oct 2020 01:02:20 AM HDT

New command output (if the output of a command-line utility has changed)

admin@sonic:~$ show clock
Sat 10 Oct 2020 01:02:20 AM HDT

admin@sonic:~$ show clock timezones
Africa/Abidjan
Africa/Accra
### More data here ##
Pacific/Wallis
UTC
Etc/UTC

admin@sonic:~$ sudo config clock timezone Europe/Ki # <TAB><TAB>
Europe/Kiev   Europe/Kirov
admin@sonic:~$ sudo config clock timezone Europe/Kiev
admin@sonic:~$ sudo config clock timezone Europe/Kie
Timezone Europe/Kie does not conform format

admin@sonic:~$ sudo config clock date 2020-10-11 1:2:4
admin@sonic:~$ sudo config clock date 20-40-50 60:70:80
Date 20-40-50 does not conform format YYYY-MM-DD
Time 60:70:80 does not conform format HH:MM:SS

@fastiuk fastiuk mentioned this pull request Apr 13, 2023
Merged
10 tasks
@fastiuk fastiuk self-assigned this Apr 13, 2023
dgsudharsan
dgsudharsan previously approved these changes Apr 13, 2023
View reviewed changes
@fastiuk fastiuk force-pushed the dev-clock-commands branch from 438db17 to 20d594e Compare April 14, 2023 20:42
@fastiuk fastiuk requested a review from dgsudharsan April 14, 2023 20:46
dgsudharsan
dgsudharsan previously approved these changes Apr 14, 2023
View reviewed changes
@Meir-renford Meir-renford mentioned this pull request Apr 18, 2023
Merged
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@fastiuk fastiuk closed this Apr 19, 2023
@fastiuk fastiuk reopened this Apr 19, 2023
@fastiuk fastiuk force-pushed the dev-clock-commands branch from 493bed1 to de611a7 Compare April 19, 2023 14:27
@fastiuk fastiuk closed this Apr 19, 2023
@fastiuk fastiuk reopened this Apr 19, 2023
@liat-grozovik liat-grozovik requested a review from yxieca April 28, 2023 05:20
yxieca
yxieca reviewed May 2, 2023
View reviewed changes
yxieca
yxieca reviewed May 2, 2023
View reviewed changes
@fastiuk fastiuk mentioned this pull request May 2, 2023
Merged
@fastiuk
Copy link
Contributor Author

fastiuk commented May 7, 2023

Ping here

dgsudharsan
dgsudharsan previously approved these changes May 8, 2023
View reviewed changes
@fastiuk fastiuk force-pushed the dev-clock-commands branch from de611a7 to b801498 Compare May 16, 2023 18:36
@fastiuk fastiuk requested review from dgsudharsan and yxieca May 17, 2023 06:18
dgsudharsan
dgsudharsan previously approved these changes May 17, 2023
View reviewed changes
yxieca
yxieca reviewed May 20, 2023
View reviewed changes
@fastiuk fastiuk force-pushed the dev-clock-commands branch from b801498 to 7408143 Compare May 22, 2023 11:35
@dgsudharsan dgsudharsan requested a review from yxieca May 24, 2023 20:54
@fastiuk fastiuk force-pushed the dev-clock-commands branch from 7408143 to cc7b7c9 Compare May 26, 2023 23:23
dgsudharsan
dgsudharsan previously approved these changes May 31, 2023
View reviewed changes
@fastiuk fastiuk force-pushed the dev-clock-commands branch 4 times, most recently from 29a7884 to dd2dc7e Compare May 31, 2023 21:20
@fastiuk fastiuk requested a review from dgsudharsan May 31, 2023 21:20
dgsudharsan
dgsudharsan previously approved these changes May 31, 2023
View reviewed changes
fastiuk and others added 3 commits June 1, 2023 00:53
@fastiuk
Implement clock CLI
78f0dda 
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
@fastiuk
Add tests for clock CLI
8cfe350 
Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
@Meir-renford @fastiuk
Update Command-Reference.md
36ba07b 
Updated relevant new CLI commands for clock mgmt
config clock timezone <timezone>
config clock date <YYYY-MM-DD> <HH:MM:SS>
show clock timezones
@fastiuk fastiuk force-pushed the dev-clock-commands branch from dd2dc7e to 36ba07b Compare May 31, 2023 21:53
@yxieca yxieca merged commit 359dfc0 into sonic-net:master Jun 2, 2023
@maipbui maipbui mentioned this pull request Jun 4, 2023
Merged
10 tasks
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Jun 5, 2023
@dprital
[submodule] Advance sonic-utilities pointer
19930c4 
Update sonic-utilities submodule pointer to include the following:
* 5c9b217 Fix issue: out of range sflow polling interval is accepted and stored in config_db ([sonic-net#2847](sonic-net/sonic-utilities#2847))
* 72ca484 Add CLI configuration options for teamd retry count feature ([sonic-net#2642](sonic-net/sonic-utilities#2642))
* 359dfc0 [Clock] Implement clock CLI ([sonic-net#2793](sonic-net/sonic-utilities#2793))
* b316fc2 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table ([sonic-net#2772](sonic-net/sonic-utilities#2772))
* dc59dbd Replace pickle by json ([sonic-net#2849](sonic-net/sonic-utilities#2849))
* a66f41c [show] replace shell=True, replace xml by lxml, replace exit by sys.exit ([sonic-net#2666](sonic-net/sonic-utilities#2666))
* 5750057 [utilities_common] replace shell=True ([sonic-net#2718](sonic-net/sonic-utilities#2718))
* 6e0ee3e [CRM][DASH] Extend CRM utility to support DASH resources. ([sonic-net#2800](sonic-net/sonic-utilities#2800))
* b2c29b0 [config] Generate sysinfo in single asic ([sonic-net#2856](sonic-net/sonic-utilities#2856))

Signed-off-by: dprital <drorp@nvidia.com>
@dprital dprital mentioned this pull request Jun 5, 2023
Closed
10 tasks
StormLiangMS pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 5, 2023
@maipbui
modify commands using utilities_common.cli.run_command and advance so…
1477f77 
…nic-utilities submodule on master (#15193)

Dependency:
sonic-net/sonic-utilities#2718

Why I did it
This PR sonic-net/sonic-utilities#2718 reduce shell=True usage in utilities_common.cli.run_command() function.

Work item tracking
Microsoft ADO (number only): 15022050
How I did it
Replace strings commands using utilities_common.cli.run_command() function to list of strings

due to circular dependency, advance sonic-utilities submodule
72ca484 (HEAD -> master, upstream/master, upstream/HEAD) Add CLI configuration options for teamd retry count feature (sonic-net/sonic-utilities#2642)
359dfc0 [Clock] Implement clock CLI (sonic-net/sonic-utilities#2793)
b316fc2 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (sonic-net/sonic-utilities#2772)
dc59dbd Replace pickle by json (sonic-net/sonic-utilities#2849)
a66f41c [show] replace shell=True, replace xml by lxml, replace exit by sys.exit (sonic-net/sonic-utilities#2666)
5750057 [utilities_common] replace shell=True (sonic-net/sonic-utilities#2718)
6e0ee3e [CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net/sonic-utilities#2800)
b2c29b0 [config] Generate sysinfo in single asic (sonic-net/sonic-utilities#2856)
pdhruv-marvell pushed a commit to pdhruv-marvell/sonic-utilities that referenced this pull request Aug 23, 2023
@fastiuk @Meir-renford @pdhruv-marvell
[Clock] Implement clock CLI (sonic-net#2793)
638537a 
* Implement clock CLI
* Add tests for clock CLI
* Update Command-Reference.md

Updated relevant new CLI commands for clock mgmt
config clock timezone <timezone>
config clock date <YYYY-MM-DD> <HH:MM:SS>
show clock timezones

---------

Signed-off-by: Yevhen Fastiuk <yfastiuk@nvidia.com>
Co-authored-by: Meir Renford <meirre@nvidia.com>
@ccy ccy mentioned this pull request Sep 4, 2023
Open
sonic-otn pushed a commit to sonic-otn/sonic-buildimage that referenced this pull request Sep 20, 2023
@maipbui @sonic-otn
modify commands using utilities_common.cli.run_command and advance so…
41da53d 
…nic-utilities submodule on master (sonic-net#15193)

Dependency:
sonic-net/sonic-utilities#2718

Why I did it
This PR sonic-net/sonic-utilities#2718 reduce shell=True usage in utilities_common.cli.run_command() function.

Work item tracking
Microsoft ADO (number only): 15022050
How I did it
Replace strings commands using utilities_common.cli.run_command() function to list of strings

due to circular dependency, advance sonic-utilities submodule
72ca484 (HEAD -> master, upstream/master, upstream/HEAD) Add CLI configuration options for teamd retry count feature (sonic-net/sonic-utilities#2642)
359dfc0 [Clock] Implement clock CLI (sonic-net/sonic-utilities#2793)
b316fc2 Add transceiver status CLI to show output from TRANSCEIVER_STATUS table (sonic-net/sonic-utilities#2772)
dc59dbd Replace pickle by json (sonic-net/sonic-utilities#2849)
a66f41c [show] replace shell=True, replace xml by lxml, replace exit by sys.exit (sonic-net/sonic-utilities#2666)
5750057 [utilities_common] replace shell=True (sonic-net/sonic-utilities#2718)
6e0ee3e [CRM][DASH] Extend CRM utility to support DASH resources. (sonic-net/sonic-utilities#2800)
b2c29b0 [config] Generate sysinfo in single asic (sonic-net/sonic-utilities#2856)
@fastiuk fastiuk deleted the dev-clock-commands branch December 14, 2023 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yxieca yxieca yxieca approved these changes

@dgsudharsan dgsudharsan dgsudharsan left review comments

Assignees

@fastiuk fastiuk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Standalone local clock setting

4 participants

@fastiuk @dgsudharsan @yxieca @Meir-renford