[config reload]Config Reload Enhancement#2693
Merged
qiluo-msft merged 6 commits intosonic-net:masterfrom Apr 11, 2023
Merged
Conversation
This was referenced Feb 23, 2023
qiluo-msft
reviewed
Feb 27, 2023
qiluo-msft
previously approved these changes
Mar 18, 2023
qiluo-msft
approved these changes
Apr 7, 2023
Collaborator
|
@dgsudharsan , looks like the PR has an issue, when updating the sonic-utilities for the sonic-buildimage, the build failed, see PR sonic-net/sonic-buildimage#14619, and the build result: https://dev.azure.com/mssonic/build/_build/results?buildId=251574&view=logs&jobId=e2a1d004-6151-514d-dd3b-ba225f574bd9&j=e2a1d004-6151-514d-dd3b-ba225f574bd9&t=84643f3d-b87b-5e33-4d3a-7ffd9da7d441 |
Collaborator
Author
|
@xumia This is due to a cyclic dependency with buildimage PR and I have updated sonic-buildimage PR with submodule update of sonic-utilities and sonic-host-services sonic-net/sonic-buildimage#13969. Once the above PR is merged you shouldn't see error |
dgsudharsan
added a commit
to dgsudharsan/sonic-utilities
that referenced
this pull request
May 26, 2023
Code changes for HLD: sonic-net/SONiC#1203 Removed the timer based checks for config reload Added db_migrator to migrate from "has_timer" to "delayed" Modified package-manager to migrate from "has_timer" to "delayed" Modified relevant files Added UT to verify
StormLiangMS
pushed a commit
that referenced
this pull request
Jun 10, 2023
Backporting #2693 What I did Code changes for HLD: sonic-net/SONiC#1203 Removed the timer based checks for config reload Added db_migrator to migrate from "has_timer" to "delayed" Modified package-manager to migrate from "has_timer" to "delayed" How I did it Modified relevant files How to verify it Added UT to verify
maxliu37
pushed a commit
to maxliu37/SONiC
that referenced
this pull request
May 3, 2024
Update sonic-utilities submodule pointer to include the following: * a1057b27 [config reload]Config Reload Enhancement ([#2693](sonic-net/sonic-utilities#2693)) * 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([#2606](sonic-net/sonic-utilities#2606)) Signed-off-by: dgsudharsan <[email protected]>
maxliu37
pushed a commit
to maxliu37/SONiC
that referenced
this pull request
May 3, 2024
Update sonic-utilities submodule pointer to include the following: * a1057b27 [config reload]Config Reload Enhancement ([#2693](sonic-net/sonic-utilities#2693)) * 04d0b34a [voq][chassis][generate_dump] [BCM] Dump only the relevant BCM commands for fabric cards ([#2606](sonic-net/sonic-utilities#2606)) Signed-off-by: dgsudharsan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Code changes for HLD: sonic-net/SONiC#1203
Removed the timer based checks for config reload
Added db_migrator to migrate from "has_timer" to "delayed"
Modified package-manager to migrate from "has_timer" to "delayed"
How I did it
Modified relevant files
How to verify it
Added UT to verify
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)