[GCU] Add Sample Unit Test for RDMA Headroom Pool Size Tuning

tests/generic_config_updater/files/feature_patch_application_test_failure.json

@@ -0,0 +1,35 @@
+{
+    "RDMA_SHARED_POOL_SIZE_CHANGE__FAILURE": {
+        "desc": "For RDMA shared pool size tuning- adjust both shared pool and headroom pool",
+        "current_config": {
+            "BUFFER_POOL": {
+                "ingress_lossless_pool": {
+                    "xoff": "4194112",
+                    "type": "ingress",
+                    "mode": "dynamic",
+                    "size": "10875072"
+                },
+                "egress_lossless_pool": {
+                    "type": "egress",
+                    "mode": "static",
+                    "size": "15982720"
+                },
+                "egress_lossy_pool": {
+                    "type": "egress",
+                    "mode": "dynamic",
+                    "size": "9243812"
+                }
+            }
+        },
+        "patch": [
+            {
+                "op": "replace",
+                "path": "/BUFFER_POOL/ingress_lossless_pool/xoff",
+                "value": "invalid_xoff"
+            }
+        ],
+        "expected_error_substrings": [
+            "Given patch will produce invalid config"
+        ]
+    }
+}

tests/generic_config_updater/files/feature_patch_application_test_success.json

@@ -0,0 +1,62 @@
+{
+    "RDMA_SHARED_POOL_SIZE_CHANGE__SUCCESS": {
+        "desc": "For RDMA shared pool size tuning- adjust both shared pool and headroom pool",
+        "current_config": {
+            "BUFFER_POOL": {
+                "ingress_lossless_pool": {
+                    "xoff": "4194112",
+                    "type": "ingress",
+                    "mode": "dynamic",
+                    "size": "10875072"
+                },
+                "egress_lossless_pool": {
+                    "type": "egress",
+                    "mode": "static",
+                    "size": "15982720"
+                },
+                "egress_lossy_pool": {
+                    "type": "egress",
+                    "mode": "dynamic",
+                    "size": "9243812"
+                }
+            }
+        },
+        "patch": [
+            {
+                "op": "replace",
+                "path": "/BUFFER_POOL/ingress_lossless_pool/xoff",
+                "value": "2155712"
+            },
+            {
+                "op": "replace",
+                "path": "/BUFFER_POOL/ingress_lossless_pool/size",
+                "value": "12913472"
+            },
+            {
+                "op": "replace",
+                "path": "/BUFFER_POOL/egress_lossy_pool/size",
+                "value": "5200000"
+            }
+        ],
+        "expected_config": {
+            "BUFFER_POOL": {
+                "ingress_lossless_pool": {
+                    "xoff": "2155712",
+                    "type": "ingress",
+                    "mode": "dynamic",
+                    "size": "12913472"
+                },
+                "egress_lossless_pool": {
+                    "type": "egress",
+                    "mode": "static",
+                    "size": "15982720"
+                },
+                "egress_lossy_pool": {
+                    "type": "egress",
+                    "mode": "dynamic",
+                    "size": "5200000"
+                }
+            }
+        }
+    }
+}

tests/generic_config_updater/gcu_feature_patch_application_test.py

@@ -0,0 +1,117 @@
+import jsonpatch
+import unittest
+import copy
+from unittest.mock import MagicMock, Mock
+from mock import patch
+
+import generic_config_updater.change_applier
+import generic_config_updater.patch_sorter as ps
+import generic_config_updater.generic_updater as gu
+from .gutest_helpers import Files
+from generic_config_updater.gu_common import ConfigWrapper, PatchWrapper
+
+running_config = {}
+
+def set_entry(config_db, tbl, key, data):
+    global running_config
+    if data != None:
+        if tbl not in running_config:
+            running_config[tbl] = {}
+        running_config[tbl][key] = data
+    else:
+        assert tbl in running_config
+        assert key in running_config[tbl]
+        running_config[tbl].pop(key)
+        if not running_config[tbl]:
+            running_config.pop(tbl)
+
+def get_running_config():
+    return running_config
+
+class TestFeaturePatchApplication(unittest.TestCase):
+    def setUp(self):
+        self.config_wrapper = ConfigWrapper()
+
+    def test_feature_patch_application_success(self):
+        # Format of the JSON file containing the test-cases:
+        #
+        # {
+        #     "<unique_name_for_the_test>":{
+        #         "desc":"<brief explanation of the test case>",
+        #         "current_config":<the running config to be modified>,
+        #         "patch":<the JsonPatch to apply>,
+        #         "expected_config":<the config after jsonpatch modification>
+        #     },
+        #     .
+        #     .
+        #     .
+        # }
+        data = Files.FEATURE_PATCH_APPLICATION_TEST_SUCCESS
+
+        for test_case_name in data:
+            with self.subTest(name=test_case_name):
+                self.run_single_success_case_applier(data[test_case_name])
+
+    def test_feature_patch_application_failure(self):
+        # Fromat of the JSON file containing the test-cases:
+        #
+        # {
+        #     "<unique_name_for_the_test>":{
+        #         "desc":"<brief explanation of the test case>",
+        #         "current_config":<the running config to be modified>,
+        #         "patch":<the JsonPatch to apply>,
+        #         "expected_error_substrings":<error substrings expected in failure output>
+        #     },
+        #     .
+        #     .
+        #     .
+        # }
+        data = Files.FEATURE_PATCH_APPLICATION_TEST_FAILURE
+
+        for test_case_name in data:
+            with self.subTest(name=test_case_name):
+                self.run_single_failure_case_applier(data[test_case_name])
+
+    def create_patch_applier(self, config):
+        global running_config
+        running_config = copy.deepcopy(config)
+        config_wrapper = self.config_wrapper
+        config_wrapper.get_config_db_as_json = MagicMock(side_effect=get_running_config)
+        change_applier = generic_config_updater.change_applier.ChangeApplier()
+        change_applier._get_running_config = MagicMock(side_effect=get_running_config)
+        patch_wrapper = PatchWrapper(config_wrapper)
+        return gu.PatchApplier(config_wrapper=config_wrapper, patch_wrapper=patch_wrapper, changeapplier=change_applier)
+
+    @patch("generic_config_updater.change_applier.get_config_db")
+    @patch("generic_config_updater.change_applier.set_config")
+    def run_single_success_case_applier(self, data, mock_set, mock_db):
+        current_config = data["current_config"]
+        mock_set.side_effect = set_entry
+        expected_config = data["expected_config"]
+        patch = jsonpatch.JsonPatch(data["patch"])
+        patch_applier = self.create_patch_applier(current_config)
+        patch_applier.apply(patch)
+        result_config = patch_applier.config_wrapper.get_config_db_as_json()
+
+        self.assertEqual(expected_config, result_config)
+
+    @patch("generic_config_updater.change_applier.get_config_db")
+    def run_single_failure_case_applier(self, data, mock_db):
+        current_config = data["current_config"]
+        patch = jsonpatch.JsonPatch(data["patch"])
+        expected_error_substrings = data["expected_error_substrings"]
+
+        try:
+            patch_applier = self.create_patch_applier(current_config)
+            patch_applier.apply(patch)
+            self.fail("An exception was supposed to be thrown")
+        except Exception as ex:
+            notfound_substrings = []
+            error = str(ex)
+
+            for substring in expected_error_substrings:
+                if substring not in error:
+                    notfound_substrings.append(substring)
+
+            if notfound_substrings:
+                self.fail(f"Did not find the expected substrings {notfound_substrings} in the error: '{error}'")