Skip to content

[sonic-utilities/scripts] Fixing FP ports issue#268

Merged
yxieca merged 1 commit intosonic-net:masterfrom
vharish02:fp_ports_bcm_init_fix
Jun 15, 2018
Merged

[sonic-utilities/scripts] Fixing FP ports issue#268
yxieca merged 1 commit intosonic-net:masterfrom
vharish02:fp_ports_bcm_init_fix

Conversation

@vharish02
Copy link
Copy Markdown
Contributor

This commit fixes the Front Panel Ports not coming up during
cold reboot and traffic being sent at line rate. The root cause
was the PCIe bus error which was caused because of the host
side not doing a gracefull shutdown calling bcm_shutdown and
soc_shutdown. The fix will call the gracefull shutdown of syncd
during reboot which in turns calls the bcm_shutdown and soc_shutdown.
Additionally added the check to make sure the script will run only when
it has root privileges otherwise it will quit.

Verified the fix by running traffic at line rate 40G from Ixia and
rebooted using script multiple times and traffic was successfully
forwarded after every reboot.

Signed-off-by: Harish Venkatraman Harish_Venkatraman@dell.com

- What I did

- How I did it

- How to verify it

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

-->

@vharish02
Copy link
Copy Markdown
Contributor Author

@yxieca Can you please review this PR

scripts/reboot Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exit [](start = 2, length = 4)

exit with error code

scripts/reboot Outdated
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

echo [](start = 2, length = 4)

output to stderr?

This commit fixes the Front Panel Ports not coming up during
cold reboot and traffic being sent at line rate. The root cause
was the PCIe bus error which was caused because of the host
side not doing a gracefull shutdown calling bcm_shutdown and
soc_shutdown. The fix will call the gracefull shutdown of syncd
during reboot which in turns calls the bcm_shutdown and soc_shutdown.
Additionally added the check to make sure the script will run only when
it has root privileges otherwise it will quit.

Verified the fix by running traffic at line rate 40G from Ixia and
rebooted using script multiple times and traffic was successfully
forwarded after every reboot.

Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
@vharish02 vharish02 force-pushed the fp_ports_bcm_init_fix branch from 66894a4 to 94ea615 Compare June 15, 2018 04:19
@yxieca yxieca merged commit ba8df2a into sonic-net:master Jun 15, 2018
lguohan pushed a commit that referenced this pull request Dec 26, 2018
This commit fixes the Front Panel Ports not coming up during
cold reboot and traffic being sent at line rate. The root cause
was the PCIe bus error which was caused because of the host
side not doing a gracefull shutdown calling bcm_shutdown and
soc_shutdown. The fix will call the gracefull shutdown of syncd
during reboot which in turns calls the bcm_shutdown and soc_shutdown.
Additionally added the check to make sure the script will run only when
it has root privileges otherwise it will quit.

Verified the fix by running traffic at line rate 40G from Ixia and
rebooted using script multiple times and traffic was successfully
forwarded after every reboot.

Signed-off-by: Harish Venkatraman <Harish_Venkatraman@dell.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
Update sonic-linux-kernel submodule to updated 202012 branch. This brings in the following commits....

```
e97f9fc [202012] Add upstreamed patches which backport support for registers for CPLD PNs (sonic-net#275)
58abcdc Merge pull request sonic-net#267 from Staphylo/202012-log-buf-len
3f16f4f Merge pull request sonic-net#268 from Staphylo/202012-emmc-fixes
a120ae7 Apply kernel patches to fix emmc unreliability
5f4a3f3 Increase log_buf_len to 1M for all architecture
```
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
* [CMIS]Fix low-power to high power mode transition

* Remove python2 tests

* Improve code coverage

* Parametrize the test

* Improve code coverage
cyw233 pushed a commit to cyw233/sonic-utilities that referenced this pull request Mar 2, 2026
…rt (sonic-net#268)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "closes #xxxx",
 "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
 issue when the PR is merged.

 If you are adding/modifying/removing any command or utility script, please also
 make sure to add/modify/remove any unit tests from the tests
 directory as appropriate.

 If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
 subcommand, or you are adding a new subcommand, please make sure you also
 update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
 your changes.

 Please provide the following information:
-->

#### What I did
Add save_chassis_modules_info() to the generate_dump to include the chassis module info to the Supervisor TechSupport.

#### How I did it
Add save_chassis_modules_info"() to generate_dump. This function only applicable to the Supervisor card. Annd following functions will be called:
show chassis module status
show chassis modules midplane-status

#### How to verify it
1) Generate the techSupport file on Supervisor by using CLI cmd: "show techsupport"
2) Download the TechSupport file and un-tar the file to verify the following two files with the correct output
```
~/sonic_dump_ixre-cpm-chassis7_20251105_183350/dump$ cat chassis_modules.midplane_status
 Name IP-Address Reachability
---------- ------------ --------------
LINE-CARD0 10.6.1.100 True
LINE-CARD1 10.6.2.100 True
LINE-CARD2 10.6.3.100 False
LINE-CARD3 10.6.4.100 False
LINE-CARD4 10.6.5.100 False
LINE-CARD5 10.6.6.100 False
LINE-CARD6 10.6.7.100 False
LINE-CARD7 10.6.8.100 False
~/duts/cpm7/sonic_dump_ixre-cpm-chassis7_20251105_183350/dump$ cat chassis_modules.status
 Name Description Physical-Slot Oper-Status Admin-Status Serial
------------ ---------------------- --------------- ------------- -------------- -----------
FABRIC-CARD0 Unavailable 1 Empty up N/A
FABRIC-CARD1 Unavailable 2 Empty up N/A
FABRIC-CARD2 Unavailable 3 Empty up N/A
FABRIC-CARD3 Unavailable 4 Empty up N/A
FABRIC-CARD4 Unavailable 5 Empty up N/A
FABRIC-CARD5 Unavailable 6 Empty up N/A
FABRIC-CARD6 SFM7 7 Online up NS215110068
FABRIC-CARD7 Unavailable 8 Empty up N/A
 LINE-CARD0 Nokia-IXR7250E-36x100G 1 Online up EAG2-02-040
 LINE-CARD1 Nokia-IXR7250E-36x100G 2 Online up EAG2-02-142
 LINE-CARD2 Unavailable 3 Empty up N/A
 LINE-CARD3 Unavailable 4 Empty up N/A
 LINE-CARD4 Unavailable 5 Empty up N/A
 LINE-CARD5 Unavailable 6 Empty up N/A
 LINE-CARD6 Unavailable 7 Empty up N/A
 LINE-CARD7 Unavailable 8 Empty up N/A
 SUPERVISOR0 Nokia-IXR7250E-SUP-10 A Online up NS243362676
mlok@mlok2:~/duts/cpm7/sonic_dump_ixre-cpm-chassis7_20251105_183350/dump$

```
#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [x] 202405
- [ ] 202411
- [ ] 202505

#### Previous command output (if the output of a command-line utility has changed)
N/A
#### New command output (if the output of a command-line utility has changed)
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants