[generate_dump]: Enhance show techsupport for Marvell platform by pavannaregundi · Pull Request #2676 · sonic-net/sonic-utilities

pavannaregundi · 2023-02-15T07:19:55Z

Change-Id: Ibb5b5a860833e8d7834a1d72756d070c61f2ab37

What I did

Added support for marvell sdk commands in "show techsupport".

How I did it

Modified the generate_dump script, to add marvell sdk commands under a proper platform check.

How to verify it

Verified the change by running "show techsupport" command and check all the newly added marvel sdk commands are collecting the correct information.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

radha-danda · 2023-04-04T14:48:46Z

@lguohan, can you help review and merge the PR please?

lguohan · 2023-04-04T14:51:12Z

@qiluo-msft can you help?

qiluo-msft · 2023-04-10T16:26:24Z

scripts/generate_dump

+
+    mkdir -p $LOGDIR/sdkdump
+    if [ "$1" = "collect SER" ];then
+        local cmd="sudo cat /var/log/syslog | grep \"Chip MARVELL occurs\""


/var/log/syslog

local cmd="sudo cat /var/log/syslog | grep "Chip MARVELL occurs""

syslog file will be rotated at any time. So this grep may not work. Since all the syslog files are already dumped, why you need grep? #Closed

Will changed this logic to collect logs from SDK.

qiluo-msft · 2023-04-10T16:27:15Z

scripts/generate_dump

+    if [ "$1" = "collect SER" ];then
+        local cmd="sudo cat /var/log/syslog | grep \"Chip MARVELL occurs\""
+    else
+        local cmd="~/mrvlcmd -c \"$1\""


~/

local cmd="~/mrvlcmd -c "$1""

It is dangerous to copy of one runable file from cotnainer to host, and run as root. show tech is expected to only show. If you really need the script in host, please build into the host image. #Closed

Will change this, to run command directed using docker exec.

qiluo-msft

As comments

Change-Id: Ibb5b5a860833e8d7834a1d72756d070c61f2ab37 Signed-off-by: Pavan Naregundi <[email protected]>

pavannaregundi · 2023-06-07T09:54:45Z

@qiluo-msft I have address your comments and pushed the changes. Please review.

qiluo-msft · 2023-06-14T21:19:57Z

scripts/generate_dump

+save_marvellcmd() {
+    trap 'handle_error $? $LINENO' ERR
+
+    mkdir -p $LOGDIR/sdkdump


sdkdump

Do you want to clean up this folder if there are old files, before you save new file? #Closed

Full path of the sdkdump will be something like below, where parenet directory(sonic_dump_sonic_XXXXXXX_XXXX) is always new each time we execute "show techsupport" command. So old file will not be present.
"/var/dump/sonic_dump_sonic_20230615_125930/dump/sdkdump/".

pavannaregundi · 2023-06-27T02:52:17Z

@qiluo-msft Let me know if you have further comments.

Update sonic-utilities submodule pointer to include the following: * ff380e0 [hash]: Implement GH frontend ([sonic-net#2580](sonic-net/sonic-utilities#2580)) * 61bad06 [db_migrator] Set correct CURRENT_VERSION, extend UT ([sonic-net#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47 [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([sonic-net#2885](sonic-net/sonic-utilities#2885)) * 73d8d63 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([sonic-net#2750](sonic-net/sonic-utilities#2750)) * 7bc08c2 [db_migrator] Remove hardcoded config and migrate config from minigraph ([sonic-net#2887](sonic-net/sonic-utilities#2887)) * b1aa942 [generate_dump]: Enhance show techsupport for Marvell platform ([sonic-net#2676](sonic-net/sonic-utilities#2676)) * 316b14c Add support for secure upgrade ([sonic-net#2698](sonic-net/sonic-utilities#2698)) * dc2945b [dns] Implement config and show commands for static DNS. ([sonic-net#2737](sonic-net/sonic-utilities#2737)) * 8414a70 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([sonic-net#2525](sonic-net/sonic-utilities#2525)) * 0b629ba Revert [chassis][voq] Clear fabric counters queue/port (2789) ([sonic-net#2882](sonic-net/sonic-utilities#2882)) * 3ba8241 [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([sonic-net#2839](sonic-net/sonic-utilities#2839)) * fceef2e [chassis][voq] Clear fabric counters queue/port ([sonic-net#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <[email protected]>

Update sonic-utilities submodule pointer to include the following: * ff380e0 [hash]: Implement GH frontend ([#2580](sonic-net/sonic-utilities#2580)) * 61bad06 [db_migrator] Set correct CURRENT_VERSION, extend UT ([#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47 [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([#2885](sonic-net/sonic-utilities#2885)) * 73d8d63 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([#2750](sonic-net/sonic-utilities#2750)) * 7bc08c2 [db_migrator] Remove hardcoded config and migrate config from minigraph ([#2887](sonic-net/sonic-utilities#2887)) * b1aa942 [generate_dump]: Enhance show techsupport for Marvell platform ([#2676](sonic-net/sonic-utilities#2676)) * 316b14c Add support for secure upgrade ([#2698](sonic-net/sonic-utilities#2698)) * dc2945b [dns] Implement config and show commands for static DNS. ([#2737](sonic-net/sonic-utilities#2737)) * 8414a70 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([#2525](sonic-net/sonic-utilities#2525)) * 0b629ba Revert [chassis][voq] Clear fabric counters queue/port (2789) ([#2882](sonic-net/sonic-utilities#2882)) * 3ba8241 [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([#2839](sonic-net/sonic-utilities#2839)) * fceef2e [chassis][voq] Clear fabric counters queue/port ([#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <[email protected]>

Update sonic-utilities submodule pointer to include the following: * ff380e0 [hash]: Implement GH frontend ([sonic-net#2580](sonic-net/sonic-utilities#2580)) * 61bad06 [db_migrator] Set correct CURRENT_VERSION, extend UT ([sonic-net#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47 [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([sonic-net#2885](sonic-net/sonic-utilities#2885)) * 73d8d63 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([sonic-net#2750](sonic-net/sonic-utilities#2750)) * 7bc08c2 [db_migrator] Remove hardcoded config and migrate config from minigraph ([sonic-net#2887](sonic-net/sonic-utilities#2887)) * b1aa942 [generate_dump]: Enhance show techsupport for Marvell platform ([sonic-net#2676](sonic-net/sonic-utilities#2676)) * 316b14c Add support for secure upgrade ([sonic-net#2698](sonic-net/sonic-utilities#2698)) * dc2945b [dns] Implement config and show commands for static DNS. ([sonic-net#2737](sonic-net/sonic-utilities#2737)) * 8414a70 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([sonic-net#2525](sonic-net/sonic-utilities#2525)) * 0b629ba Revert [chassis][voq] Clear fabric counters queue/port (2789) ([sonic-net#2882](sonic-net/sonic-utilities#2882)) * 3ba8241 [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([sonic-net#2839](sonic-net/sonic-utilities#2839)) * fceef2e [chassis][voq] Clear fabric counters queue/port ([sonic-net#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <[email protected]>

qiluo-msft self-requested a review April 10, 2023 16:22

qiluo-msft reviewed Apr 10, 2023

View reviewed changes

qiluo-msft requested changes Apr 10, 2023

View reviewed changes

[generate_dump]: Enhance show techsupport for Marvell platform

8e16578

Change-Id: Ibb5b5a860833e8d7834a1d72756d070c61f2ab37 Signed-off-by: Pavan Naregundi <[email protected]>

pavannaregundi force-pushed the master branch from 685c149 to 8e16578 Compare June 7, 2023 09:51

pavannaregundi requested a review from qiluo-msft June 8, 2023 02:42

qiluo-msft reviewed Jun 14, 2023

View reviewed changes

qiluo-msft approved these changes Jun 29, 2023

View reviewed changes

qiluo-msft merged commit b1aa942 into sonic-net:master Jun 29, 2023

dgsudharsan mentioned this pull request Jul 11, 2023

[submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#15779

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[generate_dump]: Enhance show techsupport for Marvell platform#2676

[generate_dump]: Enhance show techsupport for Marvell platform#2676
qiluo-msft merged 1 commit intosonic-net:masterfrom
pavannaregundi:master

pavannaregundi commented Feb 15, 2023

Uh oh!

radha-danda commented Apr 4, 2023

Uh oh!

lguohan commented Apr 4, 2023

Uh oh!

qiluo-msft Apr 10, 2023 •

edited

Loading

Uh oh!

pavannaregundi Jun 7, 2023

Uh oh!

qiluo-msft Apr 10, 2023 •

edited

Loading

Uh oh!

pavannaregundi Jun 7, 2023

Uh oh!

qiluo-msft left a comment

Uh oh!

pavannaregundi commented Jun 7, 2023

Uh oh!

qiluo-msft Jun 14, 2023 •

edited

Loading

Uh oh!

pavannaregundi Jun 15, 2023

Uh oh!

pavannaregundi commented Jun 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

pavannaregundi commented Feb 15, 2023

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

radha-danda commented Apr 4, 2023

Uh oh!

lguohan commented Apr 4, 2023

Uh oh!

qiluo-msft Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

local cmd="sudo cat /var/log/syslog | grep "Chip MARVELL occurs""

Uh oh!

pavannaregundi Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

qiluo-msft Apr 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

local cmd="~/mrvlcmd -c "$1""

Uh oh!

pavannaregundi Jun 7, 2023

Choose a reason for hiding this comment

Uh oh!

qiluo-msft left a comment

Choose a reason for hiding this comment

Uh oh!

pavannaregundi commented Jun 7, 2023

Uh oh!

qiluo-msft Jun 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pavannaregundi Jun 15, 2023

Choose a reason for hiding this comment

Uh oh!

pavannaregundi commented Jun 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

qiluo-msft Apr 10, 2023 •

edited

Loading

qiluo-msft Apr 10, 2023 •

edited

Loading

qiluo-msft Jun 14, 2023 •

edited

Loading