[202012][show] show logging CLI support for logs stored in tmpfs#2652
Merged
prgeor merged 1 commit intosonic-net:202012from Feb 6, 2023
Merged
[202012][show] show logging CLI support for logs stored in tmpfs#2652prgeor merged 1 commit intosonic-net:202012from
prgeor merged 1 commit intosonic-net:202012from
Conversation
Signed-off-by: Mihir Patel <patelmi@microsoft.com>
prgeor
approved these changes
Feb 6, 2023
Contributor
|
@qiluo-msft Cherry pick for #2641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihir Patel patelmi@microsoft.com
Backport of #2641
What I did
Enabling "show logging" CLI to show logs from tmpfs if it exists.
How I did it
Added a check in the CLI handler to see if the path "/var/log.tmpfs" exists and display the logs from this directory if it exists. In case if the path doesn't exist, logs will be displayed from "/var/log"
How to verify it
Following tests were performed:
For detailed test results, please refer to Unit-test_logging_cli.txt
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)