avoid printing error if no neighbors are present#2502
Merged
gechiang merged 3 commits intosonic-net:masterfrom Nov 17, 2022
Merged
avoid printing error if no neighbors are present#2502gechiang merged 3 commits intosonic-net:masterfrom
gechiang merged 3 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
gechiang
reviewed
Nov 17, 2022
gechiang
reviewed
Nov 17, 2022
gechiang
reviewed
Nov 17, 2022
Contributor
gechiang
left a comment
gechiang
left a comment
There was a problem hiding this comment.
Please make the string change as this is what was being returned by older image (20181130) such as guaga based BGP and there are services that are depended on this same output.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Contributor
Author
@gechiang updated the error strings in the latest commit |
gechiang
reviewed
Nov 17, 2022
tests/bgp_commands_test.py
Outdated
| """ | ||
|
|
||
| show_error_no_v6_neighbor = """\ | ||
| % No IPv6 neighbor is configured |
Contributor
There was a problem hiding this comment.
Please remove "% " (% and the space after it) as that is not in the original error message or the service that needs to parse it will not match...
Thanks!
gechiang
reviewed
Nov 17, 2022
gechiang
reviewed
Nov 17, 2022
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
* avoid printing error if no neighbors are present Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
mdanish-kh
pushed a commit
to mdanish-kh/sonic-utilities
that referenced
this pull request
Nov 23, 2022
* avoid printing error if no neighbors are present Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
yxieca
pushed a commit
that referenced
this pull request
Nov 29, 2022
* avoid printing error if no neighbors are present Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Contributor
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
arlakshm
added a commit
that referenced
this pull request
Jan 13, 2023
What I did Fix #2492. port #2502 in 202012 branch How I did it Use click.echo and exit instead of ctx.fail in cli handler when no neighbor information is returned from bgp container. How to verify it Test on target and add UT new output when no neighbors are present Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
Contributor
|
202012 branch PR merged: #2594 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan [email protected]
What I did
Fixes #2492
How I did it
Use
click.echoandexitinstead ofctx.failin cli handler when no neighbor information is returned from bgp container.How to verify it
Test on target and add UT
new output when no neighbors are present
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)