Do not configure physical attributes on port channels in portconfig#2456
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Nov 8, 2022
Merged
Do not configure physical attributes on port channels in portconfig#2456liat-grozovik merged 2 commits intosonic-net:masterfrom
liat-grozovik merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
keboliu
approved these changes
Oct 28, 2022
dgsudharsan
approved these changes
Oct 28, 2022
Collaborator
Author
|
@prgeor kindly reminder to review this PR. thanks. |
prsunny
approved these changes
Nov 7, 2022
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Nov 10, 2022
…2456) - What I did portconfig is a utility designed to configure various attributes on a physical port or a port channel. It should reject the operation that a user wants to configure an attribute that will be inserted into CONFIG_DB.PORT table on a port channel. Otherwise, it will generate an entry for the port channel, which causes orchagent to be aborted. Eg. the following commands will cause an error admin@sonic:~$ sudo config portchannel add PortChannel0001 admin@sonic:~$ sudo config interface speed PortChannel0001 100000 After the fix, configuring physical attributes on a port channel will be rejected - How I did it - How to verify it Unit test Signed-off-by: Stephen Sun <stephens@nvidia.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…onic-net#2456) - What I did portconfig is a utility designed to configure various attributes on a physical port or a port channel. It should reject the operation that a user wants to configure an attribute that will be inserted into CONFIG_DB.PORT table on a port channel. Otherwise, it will generate an entry for the port channel, which causes orchagent to be aborted. Eg. the following commands will cause an error admin@sonic:~$ sudo config portchannel add PortChannel0001 admin@sonic:~$ sudo config interface speed PortChannel0001 100000 After the fix, configuring physical attributes on a port channel will be rejected - How I did it - How to verify it Unit test Signed-off-by: Stephen Sun <stephens@nvidia.com>
mdanish-kh
pushed a commit
to mdanish-kh/sonic-utilities
that referenced
this pull request
Nov 23, 2022
…onic-net#2456) - What I did portconfig is a utility designed to configure various attributes on a physical port or a port channel. It should reject the operation that a user wants to configure an attribute that will be inserted into CONFIG_DB.PORT table on a port channel. Otherwise, it will generate an entry for the port channel, which causes orchagent to be aborted. Eg. the following commands will cause an error admin@sonic:~$ sudo config portchannel add PortChannel0001 admin@sonic:~$ sudo config interface speed PortChannel0001 100000 After the fix, configuring physical attributes on a port channel will be rejected - How I did it - How to verify it Unit test Signed-off-by: Stephen Sun <stephens@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
portconfigis a utility designed to configure various attributes on a physical port or a port channel.It should reject the operation that a user wants to configure an attribute that will be inserted into
CONFIG_DB.PORTtable on a port channel. Otherwise, it will generate an entry for the port channel, which causes orchagent to be aborted.Eg. the following commands
will cause the following error
After the fix, configuring physical attributes on a port channel will be rejected
Signed-off-by: Stephen Sun stephens@nvidia.com
How I did it
How to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)