Support syslog rate limit configuration for containers and host#2454
Merged
saiarcot895 merged 6 commits intosonic-net:masterfrom Dec 7, 2022
Merged
Conversation
|
This pull request introduces 3 alerts when merging 238bd67 into c2841b8 - view on LGTM.com new alerts:
|
mkeda
suggested changes
Nov 10, 2022
Collaborator
mkeda
left a comment
mkeda
left a comment
There was a problem hiding this comment.
Thank you for your work to add this feature!
Collaborator
Author
|
Hi @mkeda, I have fixed/replied all comments. Would you please review the new changes? |
mkeda
previously approved these changes
Nov 15, 2022
saiarcot895
reviewed
Dec 1, 2022
Collaborator
Author
|
Hi @saiarcot895, thanks for the comments, I have fixed it, could you please continue reviewing? |
saiarcot895
approved these changes
Dec 5, 2022
8 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 30, 2022
* Support syslog rate limit configuration for containers and host * Fix LGTM * Fix unit test issue * Add syslog_util as a package * Fix review comment * Update feature.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HLD:
sonic-net/SONiC#1049
What I did
Support CLIs for syslog rate limit feature
How I did it
Support 4 new CLIs:
config syslog rate-limit-hostshow syslog rate-limit-hostconfig syslog rate-limit-containershow syslog rate-limit-containerHow to verify it
Unit test
Previous command output (if the output of a command-line utility has changed)
N/A
New command output (if the output of a command-line utility has changed)