Skip to content

Disable "tag as local" when reboot#2451

Merged
lixiaoyuner merged 2 commits intosonic-net:masterfrom
lixiaoyuner:disable_tag_as_local
Nov 2, 2022
Merged

Disable "tag as local" when reboot#2451
lixiaoyuner merged 2 commits intosonic-net:masterfrom
lixiaoyuner:disable_tag_as_local

Conversation

@lixiaoyuner
Copy link
Contributor

@lixiaoyuner lixiaoyuner commented Oct 24, 2022

Signed-off-by: Yun Li [email protected]

What I did

Based on our new design about k8s project, this PR is to disable tag k8s scheduled image to latest when reboot, it’s done in this PR, and change k8s related config commands default value.

How I did it

  1. Set TAG_LATEST=no
  2. Change config command insecure key default value from False to True

How to verify it

  1. Execute "config kube server ip" inside SONiC device, if insecure key is empty, set it to True, then execute "show kube server config", would disply True
  2. It will not execute tag operations when reboot happens

Previous command output (if the output of a command-line utility has changed)

ip                 port            insecure          disable
----------         ----------      ------------      ---------
x.x.x.x            6443            False             False

New command output (if the output of a command-line utility has changed)

ip                 port            insecure          disable
----------         ----------      ------------      ---------
x.x.x.x            6443            True              False

@lixiaoyuner lixiaoyuner merged commit daaf0ff into sonic-net:master Nov 2, 2022
preetham-singh pushed a commit to preetham-singh/sonic-utilities that referenced this pull request Nov 21, 2022
* Disable "tag as local" when reboot

* Change INSECURE flag from False to True

Signed-off-by: Yun Li <[email protected]>
mdanish-kh pushed a commit to mdanish-kh/sonic-utilities that referenced this pull request Nov 23, 2022
* Disable "tag as local" when reboot

* Change INSECURE flag from False to True

Signed-off-by: Yun Li <[email protected]>
yxieca pushed a commit that referenced this pull request Dec 1, 2022
* Disable "tag as local" when reboot

* Change INSECURE flag from False to True

Signed-off-by: Yun Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants