Fix display disorder problem of show mirror_session#2447
Merged
prsunny merged 5 commits intosonic-net:masterfrom Nov 3, 2022
Merged
Fix display disorder problem of show mirror_session#2447prsunny merged 5 commits intosonic-net:masterfrom
prsunny merged 5 commits intosonic-net:masterfrom
Conversation
|
This pull request introduces 7 alerts when merging 0c98b3b into 25fda26 - view on LGTM.com new alerts:
|
Contributor
Author
|
@prsunny @dgsudharsan please review, Thanks! |
Contributor
Author
|
could you please review this change? Thanks!@prsunny @dgsudharsan |
dgsudharsan
approved these changes
Oct 28, 2022
prsunny
approved these changes
Nov 3, 2022
Contributor
|
@bingwang-ms for viz |
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
* Fix display disorder problem of mirror_session
mdanish-kh
pushed a commit
to mdanish-kh/sonic-utilities
that referenced
this pull request
Nov 23, 2022
* Fix display disorder problem of mirror_session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fix display disorder problem of show mirror_session
The problem is as follows, the span session and erspan session are not sorted in the name column(Take SPAN as an example, ERSPAN is similar):
root@sonic:/home/admin# show mirror_session
How I did it
Sort the name column with natsorted
How to verify it
use “show mirror_session”
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)