[watermarkstat] Add new warning message for the 'q_shared_multi' counters#2408
Merged
liat-grozovik merged 4 commits intosonic-net:masterfrom Oct 18, 2022
Merged
Conversation
…ters in case if they not in COUNTES_DB Signed-off-by: Vadym Hlushko <[email protected]>
Signed-off-by: Vadym Hlushko <[email protected]>
neethajohn
reviewed
Oct 3, 2022
Signed-off-by: Nazarii Hnydyn <[email protected]>
This reverts commit ee8ccbd.
|
This pull request fixes 1 alert when merging 03541bc into 57c509a - view on LGTM.com fixed alerts:
|
Contributor
Author
|
@neethajohn, could you please review it? |
neethajohn
approved these changes
Oct 10, 2022
neethajohn
approved these changes
Oct 17, 2022
mdanish-kh
pushed a commit
to hamnarauf/sonic-utilities
that referenced
this pull request
Oct 22, 2022
…ters (sonic-net#2408) - What I did Add a new warning message for the 'q_shared_multi' counter and not perform the exit with error code (1) because of the new implementation sonic-swss/pull/2432 from now on there is a valid case if there are no multicast counters inside the COUNTERS_DB. In order for multicast counters to be presented in COUNTERS_DB the appropriate queues should be configured inside the CONFIG_DB (e.g "BUFFER_QUEUE|Ethernet14|7-8") - How I did it Change the watermarkstat script - How to verify it Run the sonic-mgmt/tests/iface_namingmode/test_iface_namingmode.py Previous command output (if the output of a command-line utility has changed) root@sonic:/home/admin# show queue watermark multicast Object map is empty! New command output (if the output of a command-line utility has changed) root@sonic:/home/admin# show queue watermark multicast Object map from the COUNTERS_DB is empty because the multicast queues are not configured in the CONFIG_DB!
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…ters (sonic-net#2408) - What I did Add a new warning message for the 'q_shared_multi' counter and not perform the exit with error code (1) because of the new implementation sonic-swss/pull/2432 from now on there is a valid case if there are no multicast counters inside the COUNTERS_DB. In order for multicast counters to be presented in COUNTERS_DB the appropriate queues should be configured inside the CONFIG_DB (e.g "BUFFER_QUEUE|Ethernet14|7-8") - How I did it Change the watermarkstat script - How to verify it Run the sonic-mgmt/tests/iface_namingmode/test_iface_namingmode.py Previous command output (if the output of a command-line utility has changed) root@sonic:/home/admin# show queue watermark multicast Object map is empty! New command output (if the output of a command-line utility has changed) root@sonic:/home/admin# show queue watermark multicast Object map from the COUNTERS_DB is empty because the multicast queues are not configured in the CONFIG_DB!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The same PR for 202205 branch - sonic-utilities/pull/2406
Signed-off-by: Vadym Hlushko [email protected]
What I did
Add a new warning message for the 'q_shared_multi' counter and not perform the exit with error code (1) because of the new implementation sonic-swss/pull/2432 from now on there is a valid case if there are no multicast counters inside the
COUNTERS_DB.In order for multicast counters to be presented in
COUNTERS_DBthe appropriate queues should be configured inside theCONFIG_DB(e.g"BUFFER_QUEUE|Ethernet14|7-8")How I did it
Change the
watermarkstatscriptHow to verify it
Run the sonic-mgmt/tests/iface_namingmode/test_iface_namingmode.py
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)