Skip to content

[GCU]Remove GCU unique lane check for duplicate lanes platforms #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wen587 merged 9 commits into from
Sep 20, 2022
Merged

[GCU]Remove GCU unique lane check for duplicate lanes platforms #2343

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
72b8249
Remove GCU unique lane check
wen587 Aug 31, 2022
1c4096b
Add unique_lanes flags and bring most test back
wen587 Sep 1, 2022
c30e05f
missing comma
wen587 Sep 1, 2022
8eab6fa
fix test issue
wen587 Sep 1, 2022
34bfc37
resolve comment:
wen587 Sep 14, 2022
1f6d114
skip unique lane check for dup_lanes_platforms
wen587 Sep 19, 2022
6cb3a8c
resolve comment
wen587 Sep 19, 2022
7fb2c37
add todo comment
wen587 Sep 19, 2022
b1f7c3a
rm unchanged file
wen587 Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions generic_config_updater/gu_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,21 @@ def validate_lanes(self, config_db):
port_to_lanes_map[port] = lanes

# Validate lanes are unique
existing = {}
for port in port_to_lanes_map:
lanes = port_to_lanes_map[port]
for lane in lanes:
if lane in existing:
return False, f"'{lane}' lane is used multiple times in PORT: {set([port, existing[lane]])}"
existing[lane] = port
# TODO: Move this attribute (platform with duplicated lanes in ports) to YANG models
dup_lanes_platforms = [
'x86_64-arista_7050cx3_32s',
'x86_64-dellemc_s5232f_c3538-r0',
]
metadata = config_db.get("DEVICE_METADATA", {})
platform = metadata.get("localhost", {}).get("platform", None)
if platform not in dup_lanes_platforms:
existing = {}
for port in port_to_lanes_map:
lanes = port_to_lanes_map[port]
for lane in lanes:
if lane in existing:
return False, f"'{lane}' lane is used multiple times in PORT: {set([port, existing[lane]])}"
existing[lane] = port
return True, None

def validate_bgp_peer_group(self, config_db):
Expand Down