[asymmetric pfc]: Implement CLI utility for asymmetric PFC#229
Merged
sihuihan88 merged 2 commits intosonic-net:masterfrom Aug 27, 2018
Merged
[asymmetric pfc]: Implement CLI utility for asymmetric PFC#229sihuihan88 merged 2 commits intosonic-net:masterfrom
sihuihan88 merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Volodymyr Samotiy <[email protected]>
Conflicts: config/main.py show/main.py
Contributor
|
Can you add the cli output in the description as well? |
Collaborator
Author
|
Added CLI commands info to the description. |
Collaborator
Author
|
@sihuihan88 |
sihuihan88
approved these changes
Aug 27, 2018
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
6f198d0 (HEAD -> 202012, origin/202012) [Y-Cable][Broadcom] upgrade to support Broadcom Y-Cable API to release (sonic-net#230) 1c3e422 SSD Health: Retrieve SSD health and temperature values from generic SSD info (sonic-net#229) Signed-off-by: vaibhav-dahiya <[email protected]>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
…SD info (sonic-net#229) The problem: The current SSD health API uses a SSD vendor specific utility to retrieve values for overall SSD health and internal SSD temperature. These utilities are typically made available only in binary form and are not always available for all platform architectures (amd64, arm64, armhf, etc.) Vendor licensing agreements can prevent the inclusion of utility source code in the Sonic build. The solution presented here is to retrieve SSD health and temperature values from the generic SSD info retrieved via the open-source smartmontools utility (smartctl). These values can be overwritten with values retrieved using a vendor specific utility when available. smartmontools is already included in the Sonic source tree and is being built for all platform architectures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy [email protected]
- What I did
Implemented CLI utility for asymmetric PFC
- How I did it
Implemented python utility and added aliases to "config" and "show" CLI nodes.
Config command syntax:
Show command syntax and output example:
- How to verify it
Check CLI commands according to: https://github.com/Azure/SONiC/wiki/Asymmetric-PFC-High-Level-Design#23-cli