[202205][counters] Keep counters cache in a single directory#2280
Merged
yxieca merged 1 commit intosonic-net:202205from Jul 29, 2022
Merged
[202205][counters] Keep counters cache in a single directory#2280yxieca merged 1 commit intosonic-net:202205from
yxieca merged 1 commit intosonic-net:202205from
Conversation
- What I did To fix sonic-net/sonic-buildimage#9817. Cache all counters in the same place. Created a UserCache helper class to access the cache directory. - How I did it Implemented UserCache class. Changed all stats commands to use new class. Adopted fast-reboot script. - How to verify it Run on the switch and verify counters stats command and clear commands work correctly. After config reload or cold/fast reboot counters cache is removed. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
yxieca
approved these changes
Jul 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stepan Blyschak stepanb@nvidia.com
Backport of #2232
What I did
To fix Cached counter file is not cleared during config reload, causing portstat give wrong counter values sonic-buildimage#9817. Cache all counters in the same place. Created a UserCache helper class to access the cache directory.
How I did it
Implemented UserCache class. Changed all stats commands to use new class. Adopted fast-reboot script.
How to verify it
Run on the switch and verify counters stats command and clear commands work correctly. After config reload or cold/fast reboot counters cache is removed.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)