[202012] Migrate missed config on cross branch warm upgrade to 202012#2277
Merged
vaibhavhd merged 4 commits intosonic-net:202012from Jul 28, 2022
Merged
[202012] Migrate missed config on cross branch warm upgrade to 202012#2277vaibhavhd merged 4 commits intosonic-net:202012from
vaibhavhd merged 4 commits intosonic-net:202012from
Conversation
yxieca
approved these changes
Jul 27, 2022
vaibhavhd
added a commit
that referenced
this pull request
Aug 2, 2022
The script "db_migrator_constants.py" was added in the PR #2277 which did not add this script to the setup.py script. Added the new script to setup.py
vaibhavhd
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 2, 2022
…11558) To include latest warmboot fixes: [202012] [cherry-pick] Update db_migrator to support `PORT_QOS_MAP|gl (sonic-net/sonic-utilities/pull/2215) [202012] Migrate missed config on cross branch warm upgrade to 202012 (sonic-net/sonic-utilities#2277) [202012] Add db_migrator_constants.py script to setup.py (sonic-net/sonic-utilities#2287)
Collaborator
|
Hi @yxieca @vaibhavhd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Warm upgrade from 201811 (or 201911) to 202012 branch generates config which does not contain some new tables, config attributes introduced in 202012 branch.
RESTAPI,TELEMETRYandCONSOLE_SWITCH.synchronous_modeinMETADATA201811 image does not have vxlanmgrd. Thus, during warmboot from 201811 to 202012, vxlanmgrd does not do warmstart and reconciliation as restore_count for vxlanmgrd was not set in 201811 image. Since nothing is reconciled to appdb, vxlanorch has nothing to process. Hence, orchagent bake process misses VXLAN_TUNNEL* entries.
Consequently, syncd reports differences between CURRENT and TEMP view and attempts to remove VXLAN entries in new image. This remove operation fail and swss, syncd both crash.
How I did it
Advanced db_migrator version on 202012 branch to handle the new migration logic.
How to verify it
Tested on physical device and executed unit tests locally.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)