[MultiAsic] sudo reboot command doesn't gracefully stop Asic syncd# on multiasic platform#2258
Merged
abdosi merged 1 commit intosonic-net:masterfrom Jul 20, 2022
Merged
Conversation
…n multiasic platform Signed-off-by: mlok <[email protected]>
Contributor
Author
|
@judyjoseph @prgeor Please help to review this PR. Thanks. |
prgeor
approved these changes
Jul 11, 2022
Contributor
|
@abdosi can you review? |
Contributor
Author
|
@abdosi Please help review this PR, Thanks. |
yxieca
pushed a commit
that referenced
this pull request
Jul 28, 2022
…n multiasic platform (#2258) What I did Function stop_sonic_service() in /usr/local/bin/reboot script doesn't handle stopping the Asic syncd# on multiasic platform. Instead, it only stops the syncd on non-multiasic platform. When issue command "sudo reboot", the below message will be shown. admin@sonic:~$ sudo reboot Error: No such container: syncd Fixes sonic-net/sonic-buildimage#11377 How I did it Add code the stop_sonic_services() to check and get NUM_ASIC. If it is multiasic, looping all asics and call the syncd_request_shutdown for each asic. How to verify it Issue the "sudo reboot" on the multiasic platform, the error message "Error: No such container: syncd" should not be shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Function stop_sonic_service() in /usr/local/bin/reboot script doesn't handle stopping the Asic syncd# on multiasic platform. Instead, it only stops the syncd on non-multiasic platform. When issue command "sudo reboot", the below message will be shown.
Fixes sonic-net/sonic-buildimage#11377
How I did it
Add code the stop_sonic_services() to check and get NUM_ASIC. If it is multiasic, looping all asics and call the syncd_request_shutdown for each asic.
How to verify it
Issue the "sudo reboot" on the multiasic platform, the error message "Error: No such container: syncd" should not be shown.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)