Skip to content

Fix header for the output table following 'show ipv6 interface' command#2219

Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom
dprital:fix_show_ipv6_interface_output
Jun 16, 2022
Merged

Fix header for the output table following 'show ipv6 interface' command#2219
liat-grozovik merged 2 commits intosonic-net:masterfrom
dprital:fix_show_ipv6_interface_output

Conversation

@dprital
Copy link
Collaborator

@dprital dprital commented Jun 15, 2022 •
edited
Loading

What I did

Fix the header for "show ipv6 interface" output that display "IPv4" instead of "IPv6"
This PR fix the following issue: sonic-net/sonic-buildimage#11124

How I did it

Check if the table is for IPv4 or IPv6 and present the header accordingly. In addition, adjust the UT

How to verify it

Run "show ip interface" CLi command and verify that the output header present "IPv4"
Run "show ipv6 interface" CLi command and verify that the output header present "IPv6"

Previous command output (if the output of a command-line utility has changed)

root@r-bulldog-03:/usr/local/bin# show ipv6 int
Interface    Master    IPv4 address/mask                        Admin/Oper    BGP Neighbor    Neighbor IP
-----------  --------  ---------------------------------------  ------------  --------------  -------------
Bridge                 fe80::c76:fbff:fec6:86c5%Bridge/64       up/down       N/A             N/A
Ethernet0              fe80::ee0d:9aff:fe60:3900%Ethernet0/64   up/up         N/A             N/A
Ethernet4              fe80::ee0d:9aff:fe60:3900%Ethernet4/64   up/up         N/A             N/A
Ethernet8              fe80::ee0d:9aff:fe60:3900%Ethernet8/64   up/up         N/A             N/A
Ethernet12             fe80::ee0d:9aff:fe60:3900%Ethernet12/64  up/up         N/A             N/A
Ethernet14             fe80::ee0d:9aff:fe60:3900%Ethernet14/64  up/up         N/A             N/A
Ethernet16             fe80::ee0d:9aff:fe60:3900%Ethernet16/64  up/up         N/A             N/A
Ethernet18             fe80::ee0d:9aff:fe60:3900%Ethernet18/64  up/up         N/A             N/A
Ethernet20             fe80::ee0d:9aff:fe60:3900%Ethernet20/64  up/up         N/A             N/A
Ethernet21             fe80::ee0d:9aff:fe60:3900%Ethernet21/64  up/up         N/A             N/A
Ethernet22             fe80::ee0d:9aff:fe60:3900%Ethernet22/64  up/up         N/A             N/A
Ethernet23             fe80::ee0d:9aff:fe60:3900%Ethernet23/64  up/up         N/A             N/A
Ethernet24             fe80::ee0d:9aff:fe60:3900%Ethernet24/64  up/up         N/A             N/A
Ethernet25             fe80::ee0d:9aff:fe60:3900%Ethernet25/64  up/up         N/A             N/A
Ethernet26             fe80::ee0d:9aff:fe60:3900%Ethernet26/64  up/up         N/A             N/A
Ethernet27             fe80::ee0d:9aff:fe60:3900%Ethernet27/64  up/up         N/A             N/A
Ethernet28             fe80::ee0d:9aff:fe60:3900%Ethernet28/64  up/up         N/A             N/A
Ethernet32             fe80::ee0d:9aff:fe60:3900%Ethernet32/64  up/up         N/A             N/A
Ethernet36             fe80::ee0d:9aff:fe60:3900%Ethernet36/64  up/up         N/A             N/A
Ethernet40             fe80::ee0d:9aff:fe60:3900%Ethernet40/64  up/up         N/A             N/A
Ethernet44             fe80::ee0d:9aff:fe60:3900%Ethernet44/64  up/up         N/A             N/A
Ethernet48             fe80::ee0d:9aff:fe60:3900%Ethernet48/64  up/up         N/A             N/A
Ethernet52             fe80::ee0d:9aff:fe60:3900%Ethernet52/64  up/up         N/A             N/A
Ethernet56             fe80::ee0d:9aff:fe60:3900%Ethernet56/64  up/up         N/A             N/A
Ethernet60             fe80::ee0d:9aff:fe60:3900%Ethernet60/64  up/up         N/A             N/A
docker0                fd00::1/80                               up/down       N/A             N/A
                       fe80::1%docker0/64                                     N/A             N/A
eth0                   fe80::ee0d:9aff:fead:864%eth0/64         up/up         N/A             N/A
lo                     ::1/128                                  up/up         N/A             N/A

New command output (if the output of a command-line utility has changed)

root@r-bulldog-03:/usr/local/bin# show ipv6 int
Interface    Master    IPv6 address/mask                        Admin/Oper    BGP Neighbor    Neighbor IP
-----------  --------  ---------------------------------------  ------------  --------------  -------------
Bridge                 fe80::c76:fbff:fec6:86c5%Bridge/64       up/down       N/A             N/A
Ethernet0              fe80::ee0d:9aff:fe60:3900%Ethernet0/64   up/up         N/A             N/A
Ethernet4              fe80::ee0d:9aff:fe60:3900%Ethernet4/64   up/up         N/A             N/A
Ethernet8              fe80::ee0d:9aff:fe60:3900%Ethernet8/64   up/up         N/A             N/A
Ethernet12             fe80::ee0d:9aff:fe60:3900%Ethernet12/64  up/up         N/A             N/A
Ethernet14             fe80::ee0d:9aff:fe60:3900%Ethernet14/64  up/up         N/A             N/A
Ethernet16             fe80::ee0d:9aff:fe60:3900%Ethernet16/64  up/up         N/A             N/A
Ethernet18             fe80::ee0d:9aff:fe60:3900%Ethernet18/64  up/up         N/A             N/A
Ethernet20             fe80::ee0d:9aff:fe60:3900%Ethernet20/64  up/up         N/A             N/A
Ethernet21             fe80::ee0d:9aff:fe60:3900%Ethernet21/64  up/up         N/A             N/A
Ethernet22             fe80::ee0d:9aff:fe60:3900%Ethernet22/64  up/up         N/A             N/A
Ethernet23             fe80::ee0d:9aff:fe60:3900%Ethernet23/64  up/up         N/A             N/A
Ethernet24             fe80::ee0d:9aff:fe60:3900%Ethernet24/64  up/up         N/A             N/A
Ethernet25             fe80::ee0d:9aff:fe60:3900%Ethernet25/64  up/up         N/A             N/A
Ethernet26             fe80::ee0d:9aff:fe60:3900%Ethernet26/64  up/up         N/A             N/A
Ethernet27             fe80::ee0d:9aff:fe60:3900%Ethernet27/64  up/up         N/A             N/A
Ethernet28             fe80::ee0d:9aff:fe60:3900%Ethernet28/64  up/up         N/A             N/A
Ethernet32             fe80::ee0d:9aff:fe60:3900%Ethernet32/64  up/up         N/A             N/A
Ethernet36             fe80::ee0d:9aff:fe60:3900%Ethernet36/64  up/up         N/A             N/A
Ethernet40             fe80::ee0d:9aff:fe60:3900%Ethernet40/64  up/up         N/A             N/A
Ethernet44             fe80::ee0d:9aff:fe60:3900%Ethernet44/64  up/up         N/A             N/A
Ethernet48             fe80::ee0d:9aff:fe60:3900%Ethernet48/64  up/up         N/A             N/A
Ethernet52             fe80::ee0d:9aff:fe60:3900%Ethernet52/64  up/up         N/A             N/A
Ethernet56             fe80::ee0d:9aff:fe60:3900%Ethernet56/64  up/up         N/A             N/A
Ethernet60             fe80::ee0d:9aff:fe60:3900%Ethernet60/64  up/up         N/A             N/A
docker0                fd00::1/80                               up/down       N/A             N/A
                       fe80::1%docker0/64                                     N/A             N/A
eth0                   fe80::ee0d:9aff:fead:864%eth0/64         up/up         N/A             N/A
lo                     ::1/128                                  up/up         N/A             N/A

@dprital dprital changed the title Fix header for the output table when the Ip address is IPv6 Fix header for the output table following 'show ipv6 interface' command Jun 15, 2022
@liat-grozovik liat-grozovik merged commit 05c79ef into sonic-net:master Jun 16, 2022
yxieca pushed a commit that referenced this pull request Jun 17, 2022
@dprital @yxieca
Fix header for the output table following 'show ipv6 interface' comma…
789bfea 
…nd (#2219)

- What I did
Fix the header for "show ipv6 interface" output that display "IPv4" instead of "IPv6"
This PR fix the following issue: sonic-net/sonic-buildimage#11124

- How I did it
Check if the table is for IPv4 or IPv6 and present the header accordingly. In addition, adjust the UT

- How to verify it
Run "show ip interface" CLi command and verify that the output header present "IPv4"
Run "show ipv6 interface" CLi command and verify that the output header present "IPv6"
judyjoseph pushed a commit that referenced this pull request Jun 20, 2022
@dprital @judyjoseph
Fix header for the output table following 'show ipv6 interface' comma…
5800b73 
…nd (#2219)

- What I did
Fix the header for "show ipv6 interface" output that display "IPv4" instead of "IPv6"
This PR fix the following issue: sonic-net/sonic-buildimage#11124

- How I did it
Check if the table is for IPv4 or IPv6 and present the header accordingly. In addition, adjust the UT

- How to verify it
Run "show ip interface" CLi command and verify that the output header present "IPv4"
Run "show ipv6 interface" CLi command and verify that the output header present "IPv6"
yxieca pushed a commit that referenced this pull request Jun 22, 2022
@dprital @yxieca
Fix header for the output table following 'show ipv6 interface' comma…
600979e 
…nd (#2219)

- What I did
Fix the header for "show ipv6 interface" output that display "IPv4" instead of "IPv6"
This PR fix the following issue: sonic-net/sonic-buildimage#11124

- How I did it
Check if the table is for IPv4 or IPv6 and present the header accordingly. In addition, adjust the UT

- How to verify it
Run "show ip interface" CLi command and verify that the output header present "IPv4"
Run "show ipv6 interface" CLi command and verify that the output header present "IPv6"
qiluo-msft pushed a commit that referenced this pull request Jul 5, 2022
@dprital @qiluo-msft
Fix header for the output table following 'show ipv6 interface' comma…
c061a18 
…nd (#2219)

- What I did
Fix the header for "show ipv6 interface" output that display "IPv4" instead of "IPv6"
This PR fix the following issue: sonic-net/sonic-buildimage#11124

- How I did it
Check if the table is for IPv4 or IPv6 and present the header accordingly. In addition, adjust the UT

- How to verify it
Run "show ip interface" CLi command and verify that the output header present "IPv4"
Run "show ipv6 interface" CLi command and verify that the output header present "IPv6"
@neethajohn neethajohn mentioned this pull request Jul 8, 2022
Merged
neethajohn added a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 11, 2022
@neethajohn
[202012] Submodule update for sonic-utilities (#11400)
ec7cc16 
Signed-off-by: Neetha John <[email protected]>

This PR contains the following commits
5a54bd7 Added cisco config platform commands (sonic-net/sonic-utilities#2241)
62c1640 [config/load_mgmt_config] Support load IPv6 mgmt IP (sonic-net/sonic-utilities#2206)
c061a18 Fix header for the output table following 'show ipv6 interface' command (sonic-net/sonic-utilities#2219)
ecca18ff [202012] Update load minigraph to load backend acl (sonic-net/sonic-utilities#2235)
@dprital dprital deleted the fix_show_ipv6_interface_output branch January 18, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@dgsudharsan dgsudharsan Awaiting requested review from dgsudharsan

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees

No one assigned

Labels

Included in 202012 Branch Included in 202111 Branch Included in 202205 Branch Request for 202012 Branch Request for 202111 Branch Request for 202205 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dprital @liat-grozovik @qiluo-msft @yxieca @judyjoseph