Cisco-8000 show platform flexibility#2213
Merged
kevinskwang merged 1 commit intosonic-net:masterfrom Jun 20, 2022
Merged
Conversation
|
This pull request introduces 1 alert and fixes 2 when merging 2793a76 into a3d1345 - view on LGTM.com new alerts:
fixed alerts:
|
kevinskwang
approved these changes
Jun 20, 2022
Contributor
Contributor
|
cc @yxieca |
yxieca
pushed a commit
that referenced
this pull request
Jul 28, 2022
…w platform (#2213) What I did Gave cisco-8000 the ability to add sub-commands under show platform <> in our downstream repo. Currently every time we want to add/remove/update a cli, we must raise a PR upstream. How I did it I have the cisco-8000.py module import a list of click commands that are written in a module that is located in our platform code. How to verify it Run show platform -h to see all commands. We will be able to see show platform inventory. This is only available on cisco devices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Gave cisco-8000 the ability to add sub-commands under
show platform <>in our downstream repo. Currently every time we want to add/remove/update a cli, we must raise a PR upstream.How I did it
I have the cisco-8000.py module import a list of
clickcommands that are written in a module that is located in our platform code.How to verify it
Run
show platform -hto see all commands. We will be able to seeshow platform inventory. This is only available on cisco devices.Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)