[config][muxcable] fix minor config DB logic issue#2210
Merged
vdahiya12 merged 1 commit intosonic-net:masterfrom Jun 15, 2022
Merged
[config][muxcable] fix minor config DB logic issue#2210vdahiya12 merged 1 commit intosonic-net:masterfrom
vdahiya12 merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: vaibhav-dahiya <[email protected]>
zjswhhh
reviewed
Jun 11, 2022
zjswhhh
approved these changes
Jun 14, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 15, 2022
Signed-off-by: vaibhav-dahiya [email protected] For active-standby type cable there will not be any soc_ipv4 entry in the "MUX_CABLE" table, hence when updating the config DB entry with update for sudo config mux mode <state> <port> we should just check the cable_type and update the table entry if no soc_ipv4 the value written in none in that case What I did How I did it How to verify it Unit-tests cover the change Signed-off-by: vaibhav-dahiya <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya [email protected]
For active-standby type cable there will not be any soc_ipv4 entry in the "MUX_CABLE" table, hence when updating the config DB entry with update
for
sudo config mux mode <state> <port>we should just check the cable_type and update the table entry
if no soc_ipv4 the value written in none in that case
What I did
How I did it
How to verify it
Unit-tests cover the change
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)