[sonic-bootchart] add sonic-bootchart#2195
Merged
liat-grozovik merged 8 commits intosonic-net:masterfrom Jul 18, 2022
Merged
Conversation
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
|
This pull request introduces 1 alert when merging 8b76cb0 into 3197f39 - view on LGTM.com new alerts:
|
Contributor
Author
|
@qiluo-msft Could you please review? |
qiluo-msft
reviewed
Jul 5, 2022
scripts/sonic-bootchart
Outdated
|
|
||
| samples = int(bootchart_config["Bootchart"]["Samples"]) | ||
| frequency = int(bootchart_config["Bootchart"]["Frequency"]) | ||
| time = samples // frequency |
Contributor
Contributor
Author
There was a problem hiding this comment.
@qiluo-msft Added Config parsing error handling (expected key not found, non integer value and zero frequency) and corresponding unit tests
Signed-off-by: Stepan Blyschak <[email protected]>
Collaborator
|
@qiluo-msft could you please help to review and signoff following to review feedback handling? |
qiluo-msft
approved these changes
Jul 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Implemented sonic-net/SONiC#1001
How I did it
Added a new sonic-bootchart script and added UT for it
How to verify it
Run on the switch. Depends on sonic-net/sonic-buildimage#11047
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)