[subinterface] Avoid removing the subinterface when last configured ip is removed#2181
Merged
prsunny merged 1 commit intosonic-net:masterfrom May 26, 2022
Merged
Conversation
… is removed Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
keboliu
approved these changes
May 23, 2022
liat-grozovik
changed the title
Collaborator
|
@prsunny could you please review and signoff? |
prsunny
approved these changes
May 26, 2022
6 tasks
This was referenced Jun 9, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 15, 2022
… is removed (#2181) * Avoid removing the subinterface when last configured ip is removed Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com
What I did
Avoid removing the subinterface when last configured ip is removed
How I did it
In case of other interface types like INTERFACE, VLAN_INTERFACE, PORTCHANNEL_INTERFACE, when the last ip address is removed the CLI implicitly delete the interface table entry of type INTERFACE|intf_name. However this logic doesn't apply to VLAN_SUB_INTERFACE since the creation and removal will be controlled by config subinterface command
Without this fix the subinterface gets removed and show subinterface status will not list the subinterface.
How to verify it
Added UT to verify it.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)