[subinterface] Fix route add command to accept subinterface as dev#2180
Merged
prsunny merged 2 commits intosonic-net:masterfrom May 26, 2022
Merged
[subinterface] Fix route add command to accept subinterface as dev#2180prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
…as dev Signed-off-by: Sudharsan Dhamal Gopalarathnam <[email protected]>
Collaborator
|
@prsunny could you please help to review or assing someone to? |
liat-grozovik
approved these changes
May 21, 2022
keboliu
approved these changes
May 23, 2022
Collaborator
|
@prsunny could you please help to review and signoff? |
liat-grozovik
changed the title
prsunny
approved these changes
May 26, 2022
6 tasks
This was referenced Jun 9, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 15, 2022
…2180) * [subinterface]Fixing static route add command to accept subinterface as dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed route add command to accept subinterface as dev option.
How I did it
Previously VLAN_SUB_INTERFACE table was not checked when validating the dev. Added that table to the list of tables to look.
How to verify it
Added UT to verify the change
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)