[sfpshow][recycle_port] Command show interfaces transceiver presence/eeprom should not display recycle port.#2109
Merged
prgeor merged 1 commit intosonic-net:masterfrom Mar 22, 2022
Conversation
Signed-off-by: mlok <marty.lok@nokia.com>
Contributor
Author
|
@prgeor @judyjoseph Hi, This PR is to address the issue of CLI command - show interfaces transceiver eeprom/presence. Please help review it. It is also applicable to branch 202111. Thanks |
prgeor
approved these changes
Mar 22, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Mar 28, 2022
…2109) Signed-off-by: mlok <marty.lok@nokia.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
includes: 320591a [DualToR] Handle race condition between tunnel_decap and mux orchestrator (sonic-net#2114) 5027a8f Handling Invalid CRM configuration gracefully (sonic-net#2109) 0b120fa [ci]: use native arm64 and armhf pool (sonic-net#2013) 394e88a Don't handle buffer pool watermark during warm reboot reconciling (sonic-net#1987) 9008a01 patch for issue sonic-net#1971 - enable Rx Drop handling for cisco-8000 (sonic-net#2041) 2723ee3 create debug_shell_enable config to enable debug shell (sonic-net#2060) d7be0b9 [request parser] Add unit tests for request parser for multiple values (sonic-net#1766)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Command show interfaces transceiver presence/eeprom should not display recycle port.
Script sfpshow needs to skip the recycle ports since recylce port is internal port without any SFP module.
This change is applicable to the 202111 branch
How I did it
Modify the sfpshow script with using a function recirc_prefix() to check if a port is a recycle port, skip it.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)