Revert "[config reload] Fixing config reload when timer based delayed…#2017
Closed
qiluo-msft wants to merge 1 commit intosonic-net:masterfrom
Closed
Revert "[config reload] Fixing config reload when timer based delayed…#2017qiluo-msft wants to merge 1 commit intosonic-net:masterfrom
qiluo-msft wants to merge 1 commit intosonic-net:masterfrom
Conversation
… services are disabled (sonic-net#1967)" This reverts commit 055ed4f.
Collaborator
|
@qiluo-msft May I know the reason why it is reverted? |
ghooo
added a commit
that referenced
this pull request
Jan 18, 2022
…#2019) Refer to #1951 for details The PR #1951 was reverted in #2016 because it was thought to be causing the build failure in sonic-swss TestWarmReboot UTs. But it seems the failures in TestWarmReboot are still occurring e.g. #2017 [build](https://dev.azure.com/mssonic/build/_build/results?buildId=65653&view=logs&s=859b8d9a-8fd6-5a5c-6f5e-f84f1990894e) I think we can reapply #1951 and need to investigate TestWarmReboot tests instability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… services are disabled (#1967)"
This reverts commit 055ed4f.
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)