Update the example for pfcwd start command#1984
Merged
ZhaohuiS merged 2 commits intosonic-net:masterfrom Jan 5, 2022
Merged
Conversation
… it says invalid options. Update it with a correct command Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
ZhaohuiS
changed the title
Contributor
|
Looks good. Thanks for making the correction. |
Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
Contributor
Author
|
@smaheshm Thanks for the review. I have updated other related examples for pfcwd start command. |
neethajohn
approved these changes
Jan 4, 2022
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
Commits: f147d9e - 2021-10-27 : [Mux orch] Handle setting unknown mux state (sonic-net#1984) [Prince Sunny] 4618b2b - 2021-10-28 : Change tunnel orch order (sonic-net#1990) [Prince Sunny] 505d52d - 2021-10-20 : Fix the option missing in kernel config issue (sonic-net#1973) [xumia] 7bf4dfb - 2021-10-18 : SAI_REDIS_SWITCH_ATTR_CONTEXT shouldbe the last attribute. This is what sairedis library expects (sonic-net#1935) [judyjoseph] c58919e - 2021-10-08 : [logfile][202012]: Add option to specify swss rec file name (sonic-net#1946) [judyjoseph]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… it says invalid options. Update it with a correct command
Signed-off-by: Zhaohui Sun zhaohuisun@microsoft.com
What I did
The example of pfcwd start command in start function comments is a little confused, after execution, it says invalid options.
Update it with a correct command.
The output of the current example is:
admin@vlab-01:~$ sudo pfcwd start --action drop ports all detection-time 400 --restoration-time 400
Failed to run command, invalid options:
ports
detection-time
How I did it
Update the example with a correct one in pfcwd start function comments which is also usage info for pfcwd start command.
How to verify it
Enter SONiC DUT, input the following command:
sudo pfcwd start --help
sudo pfcwd start --action drop all 400 --restoration-time 400
Previous command output (if the output of a command-line utility has changed)
admin@vlab-01:~$ sudo pfcwd start --help
Usage: pfcwd start [OPTIONS] [PORTS]... DETECTION_TIME
Start PFC watchdog on port(s). To config all ports, use all as input.
Example:
sudo pfcwd start --action drop ports all detection-time 400 --restoration-
time 400
Options:
-a, --action [drop|forward|alert]
-r, --restoration-time INTEGER RANGE
--help Show this message and exit.
New command output (if the output of a command-line utility has changed)
admin@vlab-01:~$ sudo pfcwd start --help
Usage: pfcwd start [OPTIONS] [PORTS]... DETECTION_TIME
Start PFC watchdog on port(s). To config all ports, use all as input.
Example:
start --action drop all 400 --restoration-time 400
Options:
-a, --action [drop|forward|alert]
-r, --restoration-time INTEGER RANGE
--help Show this message and exit.