[debug dump util] FDB debug dump util changes by dgsudharsan · Pull Request #1968 · sonic-net/sonic-utilities

dgsudharsan · 2021-12-10T20:53:55Z

Signed-off-by: Sudharsan Dhamal Gopalarathnam sudharsand@nvidia.com

What I did

Added FDB debug dump module

How I did it

Used debug dump infra to add the FDB debug dump utility

How to verify it

Added Unit test cases to verify it.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

root@sonic:~# dump state fdb all
{
    "Vlan50:04:3f:72:e3:70:08": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d23": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x100000000093e",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d22\",\"mac\":\"04:3F:72:E3:70:08\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d23",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d23": "oid:0x20000003a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan50:04:3f:72:e3:70:08": {
                        "port": "Ethernet0",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    },
    "Vlan10:04:3f:72:ce:80:8b": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d18": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x100000000053f",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d20\",\"mac\":\"04:3F:72:CE:80:8B\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d18",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d18": "oid:0x10000003a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan10:04:3f:72:ce:80:8b": {
                        "port": "Ethernet252",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    },
    "Vlan690:04:3f:72:ce:80:8b": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d18": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x100000000053f",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d1c\",\"mac\":\"04:3F:72:CE:80:8B\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d18",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d18": "oid:0x10000003a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan690:04:3f:72:ce:80:8b": {
                        "port": "Ethernet252",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    },
    "Vlan40:04:3f:72:e3:70:09": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d16": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x2000000000d13",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d15\",\"mac\":\"04:3F:72:E3:70:09\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d16",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d16": "oid:0x3a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan40:04:3f:72:e3:70:09": {
                        "port": "PortChannel0002",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    },
    "Vlan691:04:3f:72:ce:80:8b": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d18": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x100000000053f",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d1e\",\"mac\":\"04:3F:72:CE:80:8B\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d18",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d18": "oid:0x10000003a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan691:04:3f:72:ce:80:8b": {
                        "port": "Ethernet252",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    },
    "Vlan69:04:3f:72:e3:70:09": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d16": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x2000000000d13",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d1a\",\"mac\":\"04:3F:72:E3:70:09\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d16",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d16": "oid:0x3a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan69:04:3f:72:e3:70:09": {
                        "port": "PortChannel0002",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    },
    "Vlan101:04:3f:72:e3:70:09": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d16": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x2000000000d13",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d28\",\"mac\":\"04:3F:72:E3:70:09\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d16",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d16": "oid:0x3a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan101:04:3f:72:e3:70:09": {
                        "port": "PortChannel0002",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    },
    "Vlan40:04:3f:72:ce:80:8b": {
        "APPL_DB": {
            "keys": [],
            "tables_not_found": []
        },
        "ASIC_DB": {
            "keys": [
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_BRIDGE_PORT:oid:0x3a000000000d18": {
                        "SAI_BRIDGE_PORT_ATTR_ADMIN_STATE": "true",
                        "SAI_BRIDGE_PORT_ATTR_FDB_LEARNING_MODE": "SAI_BRIDGE_PORT_FDB_LEARNING_MODE_HW",
                        "SAI_BRIDGE_PORT_ATTR_PORT_ID": "oid:0x100000000053f",
                        "SAI_BRIDGE_PORT_ATTR_TYPE": "SAI_BRIDGE_PORT_TYPE_PORT"
                    }
                },
                {
                    "ASIC_STATE:SAI_OBJECT_TYPE_FDB_ENTRY:{\"bvid\":\"oid:0x26000000000d15\",\"mac\":\"04:3F:72:CE:80:8B\",\"switch_id\":\"oid:0x21000000000000\"}": {
                        "SAI_FDB_ENTRY_ATTR_BRIDGE_PORT_ID": "oid:0x3a000000000d18",
                        "SAI_FDB_ENTRY_ATTR_PACKET_ACTION": "SAI_PACKET_ACTION_FORWARD",
                        "SAI_FDB_ENTRY_ATTR_TYPE": "SAI_FDB_ENTRY_TYPE_DYNAMIC"
                    }
                }
            ],
            "tables_not_found": [],
            "vidtorid": {
                "oid:0x3a000000000d18": "oid:0x10000003a"
            }
        },
        "STATE_DB": {
            "keys": [
                {
                    "FDB_TABLE|Vlan40:04:3f:72:ce:80:8b": {
                        "port": "Ethernet252",
                        "type": "dynamic"
                    }
                }
            ],
            "tables_not_found": []
        }
    }
}
root@sonic:~#

Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>

dgsudharsan · 2021-12-11T03:29:05Z

/azpw run

mssonicbld · 2021-12-11T03:29:06Z

/AzurePipelines run

azure-pipelines · 2021-12-11T03:29:17Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2021-12-11T04:00:16Z

/azpw run Azure.sonic-utilities

mssonicbld · 2021-12-11T04:00:17Z

/AzurePipelines run Azure.sonic-utilities

azure-pipelines · 2021-12-11T04:00:27Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-12-11T14:45:42Z

/azp run

azure-pipelines · 2021-12-11T14:45:53Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-12-14T14:32:13Z

@dgsudharsan could you please review failures?

dgsudharsan · 2021-12-14T16:23:34Z

/azpw run

mssonicbld · 2021-12-14T16:23:35Z

/AzurePipelines run

azure-pipelines · 2021-12-14T16:23:46Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2021-12-16T07:28:31Z

@dgsudharsan could you please review failures?

Looks like an infrastructure failure and it is seen across pipeline
ERROR: Could not install packages due to an OSError: [Errno 2] No such file or directory: '/__w/1/target/python-wheels/swsssdk-2.0.1-py3-none-any.whl'

@lguohan @qiluo-msft Can you please help?

qiluo-msft · 2021-12-16T23:09:36Z

It should be fixed by #1971
Could you rebase to latest code?

liat-grozovik · 2021-12-20T15:49:31Z

@SuvarnaMeenakshi kindly reminder, can you please review?

dump/plugins/fdb.py

SuvarnaMeenakshi

lgtm

What I did Added FDB debug dump module How I did it Used debug dump infra to add the FDB debug dump utility How to verify it Added Unit test cases to verify it

dgsudharsan added 6 commits November 18, 2021 00:40

[debug dump util]FDB debug dump util changes

7f20582

Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>

Adding static entry in test scenario

e2c26ca

Addressing CR

dd43eab

Addressing code review comment

a60f40c

Correcting typo

8f45ab8

Merge branch 'master' of github.com:Azure/sonic-utilities into fdb_dump

ce21a65

Merge remote-tracking branch 'upstream/master' into fdb_dump

a1cd9b5

dgsudharsan requested a review from SuvarnaMeenakshi December 20, 2021 04:36

SuvarnaMeenakshi reviewed Dec 20, 2021

View reviewed changes

dump/plugins/fdb.py Show resolved Hide resolved

Addressing review comment

0ba1c83

dgsudharsan requested a review from SuvarnaMeenakshi December 22, 2021 06:58

SuvarnaMeenakshi approved these changes Dec 22, 2021

View reviewed changes

qiluo-msft changed the title ~~[debug dump util]FDB debug dump util changes~~ [debug dump util] FDB debug dump util changes Dec 22, 2021

qiluo-msft merged commit ed2fa69 into sonic-net:master Dec 22, 2021

dgsudharsan added the Request for 202111 Branch label Jan 5, 2022

judyjoseph added the Included in 202111 Branch label Jan 9, 2022

dgsudharsan deleted the fdb_dump branch March 9, 2023 02:05

Conversation

dgsudharsan commented Dec 10, 2021

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

dgsudharsan commented Dec 11, 2021

Uh oh!

mssonicbld commented Dec 11, 2021

Uh oh!

azure-pipelines bot commented Dec 11, 2021

Uh oh!

dgsudharsan commented Dec 11, 2021

Uh oh!

mssonicbld commented Dec 11, 2021

Uh oh!

azure-pipelines bot commented Dec 11, 2021

Uh oh!

liat-grozovik commented Dec 11, 2021

Uh oh!

azure-pipelines bot commented Dec 11, 2021

Uh oh!

liat-grozovik commented Dec 14, 2021

Uh oh!

dgsudharsan commented Dec 14, 2021

Uh oh!

mssonicbld commented Dec 14, 2021

Uh oh!

azure-pipelines bot commented Dec 14, 2021

Uh oh!

dgsudharsan commented Dec 16, 2021

Uh oh!

qiluo-msft commented Dec 16, 2021

Uh oh!

liat-grozovik commented Dec 20, 2021

Uh oh!

Uh oh!

SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants