Skip to content

[pfcwd]: add command to set pfcwd polling interval#192

Merged
sihuihan88 merged 1 commit intosonic-net:masterfrom
sihuihan88:dev/sihan/poll
Feb 9, 2018
Merged

[pfcwd]: add command to set pfcwd polling interval#192
sihuihan88 merged 1 commit intosonic-net:masterfrom
sihuihan88:dev/sihan/poll

Conversation

@sihuihan88
Copy link
Contributor

@sihuihan88 sihuihan88 commented Jan 25, 2018 •
edited
Loading

Signed-off-by: Sihui Han sihan@microsoft.com

- What I did
Add command to set pfcwd polling interval
- How I did it
Add set poll interval command
- How to verify it
Test on DUT
- Previous command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# pfcwd show config                              
       PORT    ACTION    DETECTION TIME    RESTORATION TIME
-----------  --------  ----------------  ------------------
Ethernet112      drop               300                3000

- New command output (if the output of a command-line utility has changed)

root@sonic:/home/admin# pfcwd show config        
Changed polling interval to 100ms                           
       PORT    ACTION    DETECTION TIME    RESTORATION TIME 
-----------  --------  ----------------  ------------------ 
Ethernet112      drop               300                3000

-->

@sihuihan88
Copy link
Contributor Author

sihuihan88 commented Jan 25, 2018

depends on sonic-net/sonic-swss#435

marian-pritsak
marian-pritsak requested changes Jan 30, 2018
View reviewed changes
pfcwd/main.py Outdated
Copy link
Collaborator

@marian-pritsak marian-pritsak Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does someone write default value there or should we check if it's not empty?

Copy link
Contributor Author

@sihuihan88 sihuihan88 Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to display only when the value is changed.

pfcwd/main.py Outdated
Copy link
Collaborator

@marian-pritsak marian-pritsak Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to connect to COUNTERS_DB in this function

pfcwd/main.py Outdated
Copy link
Collaborator

@marian-pritsak marian-pritsak Jan 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument instead of an option?
Options are usually optional, and it's not the case for poll interval,

[pfcwd]: add command to set pfcwd polling interval
7360275 
Signed-off-by: Sihui Han <sihan@microsoft.com>
@sihuihan88 sihuihan88 merged commit dac636f into sonic-net:master Feb 9, 2018
@sihuihan88 sihuihan88 deleted the dev/sihan/poll branch February 9, 2018 21:59
zhenggen-xu added a commit to zhenggen-xu/sonic-utilities that referenced this pull request Jun 6, 2018
@zhenggen-xu
Merge branch 'github'
473c9dd 
            RB=1288101
            G=lnos-reviewers
            R=ntrianta,pmao,rmolina,sfardeen,zxu

* github:
  [acl_loader] Support Service ACL binding to multiple services (sonic-net#236)
  [show] Rename 'show session' to 'show mirror session' (sonic-net#235)
  [pfcstat]: create python cli tool to show pfc counters (sonic-net#233)
  [queuestat] add python CLI tool to show queue counters
  [acl-loader] Not to crash upon invalid rule (sonic-net#232)
  Show FDB type in fdbshow/show mac (sonic-net#231)
  [show] add 'show runningconfiguration all' subcommand (sonic-net#230)
  [reboot scripts] remove -t option in docker exec commands (sonic-net#228)
  [reboot] reduce stop service to only stop syncd (sonic-net#223)
  [crm]: Fix failures in CLI show commands (sonic-net#221)
  [Fast-reboot]: Gracefully shutdown syncd in fast-reboot (sonic-net#212)
  add fast-reboot support for nephos platform by stop kernel modules (sonic-net#220)
  [config bgp] Convert user input ipv6 addr to lower case before comparing (sonic-net#218)
  [PFCWD]: set default configuration when enabled by default (sonic-net#213)
  Add fast-reboot support for Aboot based images (sonic-net#214)
  sonic-utilities: Format show vlan config output (sonic-net#210)
  [AAA] Support login(ascii) authentication type (sonic-net#217)
  [sfputil] Adapt new way of getting PLATFORM(sonic-net#216)
  [Fast-Reboot]: Adapt fast-reboot-dump script for SAIv1.2  (sonic-net#211)
  Refactor fast-reboot script. Generate fast-reboot-dumps into configurable directory (sonic-net#208)
  Find correct opennsl module name before stopping it (sonic-net#207)
  [crm]: Add utility for CRM configuration (sonic-net#187)
  [reboot] update reboot script to retrieve platform with new format (sonic-net#206)
  Adapt to config engine change to load platform info properly (sonic-net#205)
  [config] Add qos clear and qos reload support (sonic-net#204)
  Dump default routes from APPL_DB table before fast-reboot (sonic-net#203)
  [acl_loader] Fix a crash issue when appdb is not consistent with cfgdb (sonic-net#202)
  [pfcwd]: add command to set pfcwd polling interval (sonic-net#192)
  [acl-loader] Prevent from hanging if run by non-root user (sonic-net#199)
  [config] Store ConfigDB init indicator boolean value as 1/0 in Redis to be language-agnostic (sonic-net#197)
  Get Vlan Id from SAI Vlan Object if bvid present (sonic-net#196)
  [TACACS+]: Fix aaa show error without configuration (sonic-net#191)
  'config bgp [shutdown|startup] neighbor <hostname>' now affects all sessions for neighbor (sonic-net#195)
  [sonic-clear] add a clear fdb command (sonic-net#186)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Aug 9, 2025
@mssonicbld
display proper message with proper errno for kvm. (sonic-net#192)
63b6805 
<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "closes #xxxx",
 "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
 issue when the PR is merged.

 If you are adding/modifying/removing any command or utility script, please also
 make sure to add/modify/remove any unit tests from the tests
 directory as appropriate.

 If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
 subcommand, or you are adding a new subcommand, please make sure you also
 update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
 your changes.

 Please provide the following information:
-->

#### What I did
In KVM, there is no system EEPROM. decode-syseeprom should display the information and return the correct errno (ENODEV).

Currently, on KVM, decode-syseeprom will return OK (0) even if there is no system EEPROM.

#### How I did it
Check if the platform is kvm, if so, log and return.

#### How to verify it
```
root@vlab-01:~# decode-syseeprom
Platform x86_64-kvm_x86_64-r0 does not support EEPROM
root@vlab-01:~# echo $?
19
root@vlab-01:~# python3 -c 'import os, sys; print(os.strerror(int(sys.argv[1])))' 19
No such device
```

#### Previous command output (if the output of a command-line utility has changed)
```
admin@vlab-01:~$ sudo decode-syseeprom -s
Failed to read system EEPROM info
admin@vlab-01:~$ echo $?
0
```
#### New command output (if the output of a command-line utility has changed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

@marian-pritsak marian-pritsak marian-pritsak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sihuihan88 @lguohan @marian-pritsak