Skip to content

generic_updater: Fix service validator related issues#1901

Merged
renukamanavalan merged 16 commits intosonic-net:masterfrom
renukamanavalan:updater
Nov 5, 2021
Merged

generic_updater: Fix service validator related issues#1901
renukamanavalan merged 16 commits intosonic-net:masterfrom
renukamanavalan:updater

Conversation

@renukamanavalan
Copy link
Contributor

@renukamanavalan renukamanavalan commented Oct 27, 2021

What I did

1) Copy generic_updater_config.conf.json as part of install
2) Read conf file from install dir
3) Drop empty keys & tables upon jsonpatch.JsonPatch.apply to be in sync with
   redis update
4) Prefix service_validator module path with "generic_updater"

How I did it

How to verify it

For updates on tables configured with services, the service code is invoked, as expected.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

qiluo-msft
qiluo-msft previously approved these changes Oct 28, 2021
2) Read conf file from install dir
3) Drop empty keys & tables upon jsonpatch.JsonPatch.apply to be in sync with
   redis update
4) Prefix service_validator module path with "generic_updater"
@renukamanavalan renukamanavalan changed the title generic_updater: Correct file path generic_updater: Fix service validator related issues Nov 2, 2021
@renukamanavalan renukamanavalan merged commit 095bf54 into sonic-net:master Nov 5, 2021
from .gu_common import genericUpdaterLogging


UPDATER_CONF_FILE = "/etc/sonic/generic_config_updater.conf"
Copy link
Contributor

@qiluo-msft qiluo-msft Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic_config_updater.conf

Regarding the filename, generic_config_updater.conf.json seems make more sense. It is confusing to see ..config.conf..

stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
ce8b1af9d2200c570c102a38e04cbd9659470585 (HEAD -> 201911, origin/201911) const initializer_list is not a constant expression (sonic-net#1250)
acdb03324fc268f5330d2632a02d0856f35fb880 [201911] Add lgtm.yml (sonic-net#1901)

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants