[aclshow] enhance ACL counters to work with FC infrastructure#1858
Merged
qiluo-msft merged 6 commits intosonic-net:masterfrom Nov 15, 2021
Merged
[aclshow] enhance ACL counters to work with FC infrastructure#1858qiluo-msft merged 6 commits intosonic-net:masterfrom
qiluo-msft merged 6 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
Collaborator
|
@bingwang-ms could you please help review? |
Collaborator
|
@bingwang-ms could you please help to review? |
Contributor
|
Can you please paste some example output? Thanks |
bingwang-ms
reviewed
Oct 19, 2021
bingwang-ms
reviewed
Oct 19, 2021
Signed-off-by: Stepan Blyschak <[email protected]>
bingwang-ms
previously approved these changes
Oct 20, 2021
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Nov 10, 2021
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
liat-grozovik
left a comment
liat-grozovik
left a comment
There was a problem hiding this comment.
i believe you are missing the command reference guide md file update with the new CLI.
Contributor
Author
|
@liat-grozovik There is no new CLI but there are new commands in existing "counterpoll" which is not in Command-Reference.md at all. So I considered that as a different effort to document counterpoll with all it's existing commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Made a change for aclshow and counterpoll that adds support for ACL flex counters.
DEPENDS ON: sonic-net/sonic-swss-common#533 sonic-net/sonic-sairedis#953 sonic-net/sonic-swss#1943
HLD: sonic-net/SONiC#857
How I did it
Modified aclshow and counterpoll and UT.
How to verify it
Together with depends PRs. Run ACL/Everflow test suite.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)